Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <b4a5f322d035d75c97abf2aaa19d033adc68527d.camel@linux.ibm.com>
Subject: Re: [PATCH] s390/io: Fix ioremap and iounmap undefinded issue for
 s390
From:   Niklas Schnelle <schnelle@linux.ibm.com>
To:     Chunyan Zhang <zhang.lyra@gmail.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>
Cc:     linux-s390@vger.kernel.org, kernel test robot <lkp@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>,
        LKML <linux-kernel@vger.kernel.org>
Date:   Fri, 03 Sep 2021 10:24:40 +0200
In-Reply-To: <20210903080316.2808017-1-zhang.lyra@gmail.com>
References: <20210903075641.2807623-1-zhang.lyra@gmail.com>
         <20210903080316.2808017-1-zhang.lyra@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Precedence: bulk

On Fri, 2021-09-03 at 16:03 +0800, Chunyan Zhang wrote:
> From: Chunyan Zhang <chunyan.zhang@unisoc.com>
> 
> There would not be ioremap and iounmap implementations if CONFIG_PCI is
> not set for s390, so add default declarations of these two functions
> for the case to avoid 'undefined reference' issue.
> 
> Fixes: 71ba41c9b1d9 ("s390/pci: provide support for MIO instructions")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> ---
> The issue was reported from https://lkml.org/lkml/2021/8/1/18

Thanks for the patch but I'm a little skeptical about adding
ioremap()/iounmap() stubs that don't do anything useful and on top ofn
that would do so silently.

In the above discussion you said that TIMER_OF should depend on
HAS_IOMEM. In arch/s390/Kconfig HAS_IOMEM is set if and only if
CONFIG_PCI is set so that sounds to me like it would prevent the
undefined reference without the risk of someone trying to use io*map()
without CONFIG_PCI.

At the very least I think the functions should do a WARN_ONCE() but
then we have the same situation as discussed below with Linus making it
pretty clear that he prefers these cases to be compile time checked:

https://lkml.org/lkml/2021/7/2/511


> ---
>  arch/s390/include/asm/io.h | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/s390/include/asm/io.h b/arch/s390/include/asm/io.h
> index e3882b012bfa..9438370c6445 100644
> --- a/arch/s390/include/asm/io.h
> +++ b/arch/s390/include/asm/io.h
> @@ -23,11 +23,8 @@ void unxlate_dev_mem_ptr(phys_addr_t phys, void *addr);
>  #define IO_SPACE_LIMIT 0
>  
> 
.. snip ..