Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 3 Sep 2021 11:11:43 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Aakash Hemadri <aakashhemadri123@gmail.com>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/3] staging: r8188eu: incorrect type in assignment
Message-ID: <20210903074517.GG2151@kadam>
References: <cover.1630148641.git.aakashhemadri123@gmail.com>
 <74c156553614f44a900e987f1185f3388dd740f6.1630148641.git.aakashhemadri123@gmail.com>
 <YTCZTY1WsHhTBjUE@kroah.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YTCZTY1WsHhTBjUE@kroah.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ip94hTu1AGPq9+T4UhGQuUph/+UE2hjD+P7Kqz6zY9ndqYtQ7LOdnUW4SBpz?=
 =?us-ascii?Q?OgOFjcdcZ2N8V7/gdZBg0+0fyurAzWbIG8v8CctO5OrMsjVM3crjTmdCaUfn?=
 =?us-ascii?Q?peZPKPO2YemYIeB6e6b3d2Whfq18xk7r7DseJd3BjtX3vTUpEE6Q/5j6Cv+1?=
 =?us-ascii?Q?HR2WCvrH7DH9LG+xpevueOBywZgyGoMU3n+kFpM/Yj9dd/OkpSx51sjm0NQ4?=
 =?us-ascii?Q?o7vZtJv8ge6h9VRLn+rl7xnMDsvEKVBJ+RvZJErsMTd9tS6QuA9SxZQeDxc6?=
 =?us-ascii?Q?icw8zrupfkrkyuwtJEtUcxGqHmlUhNtd94ol9AETydUSusBvkR39xgGizxnv?=
 =?us-ascii?Q?8EaN3KeYXaam1THUP2OUzCuBwFGsxBkYWs9tHYGKgz+4fdVGGQXKx9yUNynb?=
 =?us-ascii?Q?72Vc2exZ1lJ5rHFBD4xM+mFkh43UXCDm7wJR1KRv5nOi3mqtWgwbF+vGMktO?=
 =?us-ascii?Q?vAwbRzPRJhoN8+ulJqx1vJ3+Sjpmcxk4zrVoIba5h1zBVWW9vQgOvmhwDP6u?=
 =?us-ascii?Q?Kvu44Ow1SdRb1CnMQKi+J+lLoy9BQZAME5EmhNR2dKPqYiOcM0pyKFCuQqFZ?=
 =?us-ascii?Q?7cZx0DPsIJe8MzbLcSn0CtWOEIgqZCbBL/idNVG230tm2WeLI3w0F3TvzHnf?=
 =?us-ascii?Q?QhB/kCvOTTXWcYLeliUczyc6wZA2ACZI9rjOiId+Mr4cDPKJm/F2ICpjLe71?=
 =?us-ascii?Q?eJGFJ3qP8r+mE+aO0MIOW5MWDc9LNZ8RXUt1V5f0TE6LrR+bkk4E/88uR7cF?=
 =?us-ascii?Q?QXgYDaDicm+wMLDBt3KcitRjhfGe1tciyTSwTYihS0e97gwD20PuNLMqSjG1?=
 =?us-ascii?Q?531+vV4SDnIWloPuU2NXxKonaLBMIS0HB3PH/RAZGbRzPXmm7qspkmUhs9P9?=
 =?us-ascii?Q?Yo+T5X8qJ0Y3u/AFNJ3wXaWocK2y5eNPLf6yn6DSBdS1VSVfApvS/7Bfny6o?=
 =?us-ascii?Q?QQGbS6ojOFsAeVyFEgX+HnmCsHtViVCma49tJAITiInzIeeQYgFSccMJK1g3?=
 =?us-ascii?Q?A22xiIJPLWbLcAU0fSVRY9PMjKRV4eUT7FsAr5tvu6nrcExrk8nI8aPALTeK?=
 =?us-ascii?Q?SJAWoBwRt3jzOAdOdOj5bRw3gv6i9BiBaJQW1RdVbrKYvqYlPG6oxxs04bLb?=
 =?us-ascii?Q?qVkuxbaFoxaeQG50BJ+KctUC2KpsCekXKyXOvQef6DiCQhB1z8J+K23KhrwV?=
 =?us-ascii?Q?VpLndtsYO0f2F8IJaDf0KSJDyfQQUZmxtdKWEiFSAmlVahNxUeBGpuz5PqJn?=
 =?us-ascii?Q?pyGYLB+cDJ1yVLsCcOV4mz2+OimLzDvO5kC60dPC6/Dyfwbe1gFFoS+ItpsK?=
 =?us-ascii?Q?Bz8mIVRDqQyJjEy6PYjHQv04?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8655f84e-b328-4629-07db-08d96eb28178
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2021 08:12:00.6935
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ry8GYDT7Jzqri+iuOIq0c4A7jqJVgCC2MjK52kyfj6BSb66+jHQz4K1Uh9jY78DcQQVXv/LG1vh2thL2uC54d7xrDNfR7GUtTqPibt3tExg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1245
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10095 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000
 definitions=main-2109030049
X-Proofpoint-ORIG-GUID: 67EWmgM9l_AnnILfVdx36aTftkW3imHS
X-Proofpoint-GUID: 67EWmgM9l_AnnILfVdx36aTftkW3imHS
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 02, 2021 at 11:28:45AM +0200, Greg Kroah-Hartman wrote:
> On Sat, Aug 28, 2021 at 04:40:46PM +0530, Aakash Hemadri wrote:
> > @@ -512,7 +512,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method)
> >  						tag->tag_len = htons(MAGIC_CODE_LEN+RTL_RELAY_TAG_LEN+old_tag_len);
> >  
> >  						/*  insert the magic_code+client mac in relay tag */
> > -						pMagic = (unsigned short *)tag->tag_data;
> > +						pMagic = (__be16 *)tag->tag_data;
> 
> Is this whole function ever actually called?
> 
> Can someone run a ftrace on the driver to see if this function ever
> runs, and if not, remove it?
> 

Yeah.  That was my thinking when reviewing this patchset is that the NAT
stuff is probably not well tested.  It's only used for WIFI_STATION_STATE
or WIFI_ADHOC_STATE.

I don't think it's dead code but having NAT code in the driver is the
wrong layer probably?

regards,
dan carpenter