Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp428207pxb; Fri, 3 Sep 2021 05:32:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIxnj+0+Akaa4tl+lonA6hUBavDt9+O15CmePs8PuZaCrVrZfKCiCPJmhniYolbdqWMH38 X-Received: by 2002:a05:6638:1646:: with SMTP id a6mr2436112jat.27.1630672375559; Fri, 03 Sep 2021 05:32:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630672375; cv=none; d=google.com; s=arc-20160816; b=RBSGtvyRRWwjNHm8TrupcFsmlIccx5PgqH7+b8MEFZ5P4SLZXX0qBnpoNR/DPc78j8 3kWDffaWZBzno1/xsDueDjU+4tkfHJXhWK3E+lD5TNmLkWDpmyl16jkZbzpo01HRZkGN Fm2JuIQPPkhyhiaT/WKoIFgNz/sBIYDVB4/Xw8R+UI0cOLBQ4V3gjDXb1L8DWCedRXiw CZND6W1/UrYl/p7jsjqN79FjwQ6RTXtTZl/KfTdyTyXoSDwZI7oOKxL+UaKBl1XRvUAb DX70iNPqG9/CCAiUquG7NWx9VygAQ6JL3X0iKjjHzUhwEJdkMrAUJxRQaMJJ/cPVQy+u lR6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=UCgmlX5/8cxadCy3WKOzB7MntKtf+GoZcufBRXrI4Gc=; b=tmrmUbxlRSdf3N0pzZ95eKcPHBr7z3F0y2avgWA8w/JmvQokjTiCZluOEuA+Cs4XSJ puPUCYC8F+2yMWtOxuKkLfTjw+ShgcBwNAAGwpGGNeo9YKJFC8dvzCeo12BKRmh4HTXj wF/laP7zC7yWkt78QjsNcJgXUdU2E2KLibHk8ccAF5oRmiz8SYSa+bUn5lnLHTpuvoMs zGzfA+kfoWHDfohbeaxLYmB9njPyAxjNWUKoMl72QYBkoOrMZnMvXfCiCIyobmG4Xc85 1uK6fJM9FqRLGqNuufpFpdfyUsIycGQ7XbuwO6Hh2BDNhImfLdafA1zjhbdVDfYtF71W L8Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kaspersky.com header.s=mail202102 header.b=rgHEgpf3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kaspersky.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v66si6226243iof.105.2021.09.03.05.32.40; Fri, 03 Sep 2021 05:32:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kaspersky.com header.s=mail202102 header.b=rgHEgpf3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kaspersky.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349346AbhICMby (ORCPT + 99 others); Fri, 3 Sep 2021 08:31:54 -0400 Received: from mx12.kaspersky-labs.com ([91.103.66.155]:59594 "EHLO mx12.kaspersky-labs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230005AbhICMbx (ORCPT ); Fri, 3 Sep 2021 08:31:53 -0400 Received: from relay12.kaspersky-labs.com (unknown [127.0.0.10]) by relay12.kaspersky-labs.com (Postfix) with ESMTP id 9D36876481; Fri, 3 Sep 2021 15:30:51 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kaspersky.com; s=mail202102; t=1630672251; bh=UCgmlX5/8cxadCy3WKOzB7MntKtf+GoZcufBRXrI4Gc=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=rgHEgpf3bfo9fWrUrrbSTG8dNtWXt8xflRx7Ypo2RcPRZrU3kPo2k1+XzMpU0u58T L6FGICVCngefMynX1lfJ4Pd2wJ78FZcBycUjt3E+4YPAxdxeBMdDW8TRJ7FiIaU24I k/T24eAi6O3ENm5TAT/B4A8fREO6BV5d4wZdHHKQ6wxE1iYGM1VBnR7GuCeHfx/wyN L+GOGaiCXXJJH52J2sLkJV9pgJ9bUeJKZdlEmCBN8HknuRKhzVOOOWdypzMGfZzDsL 0IUoZ6wWLSRgYmXhzf8hfSMBr4xwgUecVZxD+E5FcFrxvSDtBj/Gxt7pFmRX7n9mQh 5/A2bOggUfJHQ== Received: from mail-hq2.kaspersky.com (unknown [91.103.66.206]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail-hq2.kaspersky.com", Issuer "Kaspersky MailRelays CA G3" (verified OK)) by mailhub12.kaspersky-labs.com (Postfix) with ESMTPS id CA35876484; Fri, 3 Sep 2021 15:30:50 +0300 (MSK) Received: from arseniy-pc.avp.ru (10.64.68.129) by hqmailmbx3.avp.ru (10.64.67.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 3 Sep 2021 15:30:48 +0300 From: Arseny Krasnov To: Stefan Hajnoczi , Stefano Garzarella , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Arseny Krasnov , Colin Ian King , Norbert Slusarek , Andra Paraschiv CC: , , , , , Subject: [PATCH net-next v5 0/6] virtio/vsock: introduce MSG_EOR flag for SEQPACKET Date: Fri, 3 Sep 2021 15:30:13 +0300 Message-ID: <20210903123016.3272800-1-arseny.krasnov@kaspersky.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.64.68.129] X-ClientProxiedBy: hqmailmbx2.avp.ru (10.64.67.242) To hqmailmbx3.avp.ru (10.64.67.243) X-KSE-ServerInfo: hqmailmbx3.avp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.20, Database issued on: 09/03/2021 12:09:11 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 165955 [Sep 03 2021] X-KSE-AntiSpam-Info: Version: 5.9.20.0 X-KSE-AntiSpam-Info: Envelope from: arseny.krasnov@kaspersky.com X-KSE-AntiSpam-Info: LuaCore: 461 461 c95454ca24f64484bdf56c7842a96dd24416624e X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;kaspersky.com:7.1.1;arseniy-pc.avp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Deterministic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 09/03/2021 12:14:00 X-KSE-AttachmentFiltering-Interceptor-Info: no applicable attachment filtering rules found X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 03.09.2021 6:49:00 X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-KSE-AttachmentFiltering-Interceptor-Info: no applicable attachment filtering rules found X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-KLMS-Rule-ID: 52 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Status: not scanned, disabled by settings X-KLMS-AntiSpam-Interceptor-Info: not scanned X-KLMS-AntiPhishing: Clean, bases: 2021/09/03 11:02:00 X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, bases: 2021/09/03 06:49:00 #17152626 X-KLMS-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patchset implements support of MSG_EOR bit for SEQPACKET AF_VSOCK sockets over virtio transport. First we need to define 'messages' and 'records' like this: Message is result of sending calls: 'write()', 'send()', 'sendmsg()' etc. It has fixed maximum length, and it bounds are visible using return from receive calls: 'read()', 'recv()', 'recvmsg()' etc. Current implementation based on message definition above. Record has unlimited length, it consists of multiple message, and bounds of record are visible via MSG_EOR flag returned from 'recvmsg()' call. Sender passes MSG_EOR to sending system call and receiver will see MSG_EOR when corresponding message will be processed. Idea of patchset comes from POSIX: it says that SEQPACKET supports record boundaries which are visible for receiver using MSG_EOR bit. So, it looks like MSG_EOR is enough thing for SEQPACKET and we don't need to maintain boundaries of corresponding send - receive system calls. But, for 'sendXXX()' and 'recXXX()' POSIX says, that all these calls operates with messages, e.g. 'sendXXX()' sends message, while 'recXXX()' reads messages and for SEQPACKET, 'recXXX()' must read one entire message from socket, dropping all out of size bytes. Thus, both message boundaries and MSG_EOR bit must be supported to follow POSIX rules. To support MSG_EOR new bit was added along with existing 'VIRTIO_VSOCK_SEQ_EOR': 'VIRTIO_VSOCK_SEQ_EOM'(end-of-message) - now it works in the same way as 'VIRTIO_VSOCK_SEQ_EOR'. But 'VIRTIO_VSOCK_SEQ_EOR' is used to mark 'MSG_EOR' bit passed from userspace. This patchset includes simple test for MSG_EOR. Arseny Krasnov(6): virtio/vsock: rename 'EOR' to 'EOM' bit. virtio/vsock: add 'VIRTIO_VSOCK_SEQ_EOR' bit. vhost/vsock: support MSG_EOR bit processing virtio/vsock: support MSG_EOR bit processing af_vsock: rename variables in receive loop vsock_test: update message bounds test for MSG_EOR drivers/vhost/vsock.c | 28 +++++++++++++---------- include/uapi/linux/virtio_vsock.h | 3 ++- net/vmw_vsock/af_vsock.c | 10 ++++---- net/vmw_vsock/virtio_transport_common.c | 23 ++++++++++++------- tools/testing/vsock/vsock_test.c | 8 ++++++- 5 files changed, 45 insertions(+), 27 deletions(-) v4 -> v5: - Move bitwise and out of le32_to_cpu() in 0003. v3 -> v4: - 'sendXXX()' renamed to 'send*()' in 0002- commit msg. - Comment about bit restore updated in 0003-. - 'same' renamed to 'similar' in 0003- commit msg. - u32 used instead of uint32_t in 0003-. v2 -> v3: - 'virtio/vsock: rename 'EOR' to 'EOM' bit.' - commit message updated. - 'VIRTIO_VSOCK_SEQ_EOR' bit add moved to separate patch. - 'vhost/vsock: support MSG_EOR bit processing' - commit message updated. - 'vhost/vsock: support MSG_EOR bit processing' - removed unneeded 'le32_to_cpu()', because input argument was already in CPU endianness. v1 -> v2: - 'VIRTIO_VSOCK_SEQ_EOR' is renamed to 'VIRTIO_VSOCK_SEQ_EOM', to support backward compatibility. - use bitmask of flags to restore in vhost.c, instead of separated bool variable for each flag. - test for EAGAIN removed, as logically it is not part of this patchset(will be sent separately). - cover letter updated(added part with POSIX description). Signed-off-by: Arseny Krasnov -- 2.25.1