Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp461985pxb; Fri, 3 Sep 2021 06:10:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjbRqm4K1vHYAOAl/x5NsKVBXC3BnwzGws9HvRzpwvGeR5ZfW8TLFhAvVq0eCKk6fQRIT0 X-Received: by 2002:adf:9d47:: with SMTP id o7mr4156279wre.50.1630674626373; Fri, 03 Sep 2021 06:10:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630674626; cv=none; d=google.com; s=arc-20160816; b=IuW8x0gYnkX2HmEYcGatIp6SaXgCuDlfZPhFkfWYSgFL55GImzjrYMhuHNhQTv1Gc8 Belx5AXpB9yY47PCYggGb6iZsDe8GgI/Gmdrjc/cZa0Dw1+jp3cTTh9P5NHr9vnpTEW1 PNaW6uG5mYCq6Ko+wOJIZLa8qFceH/mzTmIO64AZFElAvRwlF1FqcVnLUmcVYKfKuI1s wp7SPairrrz1lkhMBTGRpGUPRThReTGhIk6SxBAERtLKTuzgKg98pzQi8pARn/BKo74m Li1N2x7KDb0HJ9f2c22b1ZFqaBdD6uL0FwehN9d8vq5iaCC9pL99ASOqh8AHS9hwZxhU h2Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=09TsPIb4fXxY2VJx6kdGXIqWorLQ2YYQZCBibzSAYxI=; b=lhTyL/a69plh4mUXi0YXSAwY3AJL0Q5kdsjHFBSbB0UI8ZBjNKYEwhbCM7W0cacFAU 8Q7PzxPE9GxyO691laCUJIIrEaKAs8KIvVYdiRAG2oatUcKzi+adxp4tOevuhs5zbIHP Z4nVXxAAIiTu4Y1IzUKIhBv1obJsK4S8SApTMiE18bM7no8cNTzd/mTzzjh8htMR1J0z /m5I3ppeH+CVyW/GNy3ztS6IVdCZMTLlmp9C4lYFbVdYowON3rF5+zPE0ZTvw6A/lheu HYiZTPNPq2ruZvgj8WbfTLyjTVH0hAwFwIiUdj+iiGexPS3RQqTdxaEdaHGTLAQcPyb0 CIPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="p1Sk/Hqy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s22si5174317edx.408.2021.09.03.06.09.57; Fri, 03 Sep 2021 06:10:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="p1Sk/Hqy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348996AbhICMR5 (ORCPT + 99 others); Fri, 3 Sep 2021 08:17:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235288AbhICMR4 (ORCPT ); Fri, 3 Sep 2021 08:17:56 -0400 Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A408C061757 for ; Fri, 3 Sep 2021 05:16:57 -0700 (PDT) Received: by mail-il1-x131.google.com with SMTP id u7so4994753ilk.7 for ; Fri, 03 Sep 2021 05:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=09TsPIb4fXxY2VJx6kdGXIqWorLQ2YYQZCBibzSAYxI=; b=p1Sk/HqyZvS2/jQ16k+A7jzv5x5BnKiB/RxQegu2rH8Ld7j57FDdequtGt21jUW68/ cuXINnFJsylSpRWjnRELUe+nZ8ANYCoTSF1kOYtUdXYCn/C/znxsaqt7oK0qFNlDJNPE XiaVaY4SvPTuk0/KwmryQz/hahFjlfh/RXsn0yLdvwn/r3RpWy6N2zyQ2fw4N7esGclw m5JJzZ/G3um+Izf6Wert7LUbilXZpPx7nKemuYG9EvJI5Fbq3WVaOO+xA3kZxbC4x5fr DRSL7v7NeMftcUxL1XqvKV0pCsOFaeiRdbORvzwe/uY2GxNkzTG9dpAjQVfoH3nKJ8B5 51dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=09TsPIb4fXxY2VJx6kdGXIqWorLQ2YYQZCBibzSAYxI=; b=aBL5fULCEPB/h5nkhUUK3kmxYNXd/rnDQADlserM1ZXW2A2rwf33nMSHv4i5HdGQtI xb6jjmaY4N7wWUzO/ipveAXPY26nro3CBmg11HAQMLeJ+BAq3emHJAg4LO/LFhuIvq6p D6KTXY48sZzhyFYkb8e34lbm/gGcq6AECY3Cj10sOjmZmaiKT/4wmW98pMEGZT7wDhoB 6ARe5cjn/xDYQyxcm+QElOypMySnV0egG4mmqsmm+TsmcoUcVsSIpy9NSfY4T1z0elsc cFDSjLOUnQ9Mfqo24zOl/727cF1YNsb7JcwKKEzN3dyeC5CmT0cGdlSPLsSln9fSqz64 7krA== X-Gm-Message-State: AOAM530bUtIZnIvU0WxO49zO4VZzGEZOaUtcNS58klt9oXrmJZls3gXC cFocl5+1o9kfd1+IRS4w03lLTbz9o2sRyA== X-Received: by 2002:a05:6e02:524:: with SMTP id h4mr2321673ils.203.1630671416183; Fri, 03 Sep 2021 05:16:56 -0700 (PDT) Received: from [192.168.1.116] ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id z6sm2532738ilp.9.2021.09.03.05.16.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 05:16:55 -0700 (PDT) Subject: Re: [PATCH][next] io_uring: Fix a read of ununitialized pointer tctx To: Colin King , Pavel Begunkov , io-uring@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210903113535.11257-1-colin.king@canonical.com> From: Jens Axboe Message-ID: <5e5e1bb9-c5d3-d668-8a61-f70538ef92df@kernel.dk> Date: Fri, 3 Sep 2021 06:16:53 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210903113535.11257-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/3/21 5:35 AM, Colin King wrote: > From: Colin Ian King > > In the unlikely case where ctx->flags & IORING_SETUP_SQPOLL is true > and sqd is NULL the pointer tctx is not assigned a valid value and > can contain a garbage value when it is dereferenced. Fix this by > initializing it to NULL. Doh - thanks, I folded this one in. -- Jens Axboe