Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <c7bd15d7144dc87e473c7cc0a7f825f27527d15c.camel@gmail.com>
Subject: Re: [PATCH] tracing: Dynamically allocate the per-elt hist_elt_data
 array
From:   Artem Bityutskiy <dedekind1@gmail.com>
To:     Tom Zanussi <zanussi@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>
Cc:     linux-kernel@vger.kernel.org
Date:   Fri, 03 Sep 2021 16:52:29 +0300
In-Reply-To: <d52ae0ad5e1b59af7c4f54faf3fc098461fd82b3.camel@kernel.org>
References: <d52ae0ad5e1b59af7c4f54faf3fc098461fd82b3.camel@kernel.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2021-09-02 at 15:57 -0500, Tom Zanussi wrote:
> Setting the hist_elt_data.field_var_str[] array unconditionally to a
> size of SYNTH_FIELD_MAX elements wastes space unnecessarily.  The
> actual number of elements needed can be calculated at run-time
> instead.
> 
> In most cases, this will save a lot of space since it's a per-elt
> array which isn't normally close to being full.  It also allows us to
> increase SYNTH_FIELD_MAX without worrying about even more wastage when
> we do that.
> 
> Signed-off-by: Tom Zanussi <zanussi@kernel.org>

Many thanks Tom! I've tested this one.

Tested-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>