Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp574249pxb; Fri, 3 Sep 2021 08:28:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsm04xEdUg5KVOP0fqlMBXA9nHFgMtPAGJCfMr7kVRUXiNBQEuN5CYFlg6TSL/5pUb1nb6 X-Received: by 2002:a17:907:3e03:: with SMTP id hp3mr4854893ejc.183.1630682891882; Fri, 03 Sep 2021 08:28:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630682891; cv=none; d=google.com; s=arc-20160816; b=rumkWC4PcSu63q7l+mOG/2eC2PXL+vHNw3l0vaNSo7AfPRXwMdi0BWwdDDKp8Up6Z+ Usw7sIzYJGZfe3q8wG23Txg8+gwWxwXIu8aQHEhWbzL5Le7MHPUaLo7n/01XJX07kR2r 7EveNbM79yrtg6ZEkoqHbMqakIAbAH93+sTOhPwTs/Eg3mZwZZiakTuAdo/DoXI5dQZ3 FTBn63y6F2JquYhPolU/8/c3qFiLf07pMFL7rOdBMU3yh1gRV+7kXmthauGLJZE6fS/a 0fbBASwb5K/+za7GHQ0sBc8QUQTNNykU55Ia7kGOLtAShUOx0jRGZ+nuM69c+Tjc+GEW o7Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FWALQBvzU+R41Zk/e9uMwLuEm9ztHruG7nkdG+hizdg=; b=y1jeZ3V0yHWkZgD6Nira5HEUxDGdr2iVS1Rt/mQPKSrYs2K/BLQaJqtcP7u+xBKghK yzkTpE6oYdOj94hOY7cI5HcQeUHmRsp22ATJm+GnkIAEmzXgnyGAjOkZyX21Bny28Sb1 9G248bzer63p9B3Kcdlrf8L77bcYgyLb5mqMe0R9wOwn9FXmUerPG5gXDP8jRyqt3roR AuD6KKzi0dqslKmWlx6RZ9iaDw3G+dTiOOMrXplXPEz4H6qIOaUVpxAwcjPgNuP1SQpS 7PZrf/CpzFIQWt3xzXFz0cgx4fVdY2FzOGvNC2YcNSaSE6kj7TSjIxhvctwS6NZzNVEm 94ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iryaRlwZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w10si6475323ejv.584.2021.09.03.08.27.47; Fri, 03 Sep 2021 08:28:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iryaRlwZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349799AbhICP06 (ORCPT + 99 others); Fri, 3 Sep 2021 11:26:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:36577 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349749AbhICP0r (ORCPT ); Fri, 3 Sep 2021 11:26:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630682746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FWALQBvzU+R41Zk/e9uMwLuEm9ztHruG7nkdG+hizdg=; b=iryaRlwZVSVZeOa1KYKGkGIW/YF0gnRSQF2nxD+qR2CIS8uGrt218Ueg64rq6x7ObOJi1x TA5NrBD7jRVJiN/Q/XtgN26Ptuv4Y+fOFKJaLnSkRLFLdIePod7xUw5+XozSqIScLRqrI0 vPEfcF7Thv6nuFtLkb4ZFnjlteZvIWQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-532-0_3urZ0nOJ-EfhiYVhYRXA-1; Fri, 03 Sep 2021 11:25:45 -0400 X-MC-Unique: 0_3urZ0nOJ-EfhiYVhYRXA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BD0AA80198A; Fri, 3 Sep 2021 15:25:43 +0000 (UTC) Received: from virtlab512.virt.lab.eng.bos.redhat.com (virtlab512.virt.lab.eng.bos.redhat.com [10.19.152.206]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D9C46F7E3; Fri, 3 Sep 2021 15:25:33 +0000 (UTC) From: Nitesh Narayan Lal To: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, huangguangbin2@huawei.com, huangdaode@huawei.com, mtosatti@redhat.com, juri.lelli@redhat.com, frederic@kernel.org, abelits@marvell.com, bhelgaas@google.com, rostedt@goodmis.org, peterz@infradead.org Cc: nilal@redhat.com, jesse.brandeburg@intel.com, robin.murphy@arm.com, mingo@kernel.org, jbrandeb@kernel.org, akpm@linuxfoundation.org, sfr@canb.auug.org.au, stephen@networkplumber.org, rppt@linux.vnet.ibm.com, chris.friesen@windriver.com, maz@kernel.org, nhorman@tuxdriver.com, pjwaskiewicz@gmail.com, sassmann@redhat.com, thenzl@redhat.com, james.smart@broadcom.com, dick.kennedy@broadcom.com, jkc@redhat.com, faisal.latif@intel.com, shiraz.saleem@intel.com, tariqt@nvidia.com, ahleihel@redhat.com, kheib@redhat.com, borisp@nvidia.com, saeedm@nvidia.com, tatyana.e.nikolova@intel.com, mustafa.ismail@intel.com, ahs3@redhat.com, leonro@nvidia.com, chandrakanth.patil@broadcom.com, bjorn.andersson@linaro.org, chunkuang.hu@kernel.org, yongqiang.niu@mediatek.com, baolin.wang7@gmail.com, poros@redhat.com, minlei@redhat.com, emilne@redhat.com, jejb@linux.ibm.com, martin.petersen@oracle.com, kabel@kernel.org, viresh.kumar@linaro.org, kuba@kernel.org, kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, sathya.prakash@broadcom.com, sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com, tglx@linutronix.de, ley.foon.tan@intel.com, jbrunet@baylibre.com, johannes@sipsolutions.net, snelson@pensando.io, lewis.hanly@microchip.com, benve@cisco.com, _govind@gmx.com, jassisinghbrar@gmail.com Subject: [PATCH v6 06/14] RDMA/irdma: Use irq_update_affinity_hint Date: Fri, 3 Sep 2021 11:24:22 -0400 Message-Id: <20210903152430.244937-7-nitesh@redhat.com> In-Reply-To: <20210903152430.244937-1-nitesh@redhat.com> References: <20210903152430.244937-1-nitesh@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver uses irq_set_affinity_hint() to update the affinity_hint mask that is consumed by the userspace to distribute the interrupts. However, under the hood irq_set_affinity_hint() also applies the provided cpumask (if not NULL) as the affinity for the given interrupt which is an undocumented side effect. To remove this side effect irq_set_affinity_hint() has been marked as deprecated and new interfaces have been introduced. Hence, replace the irq_set_affinity_hint() with the new interface irq_update_affinity_hint() that only updates the affinity_hint pointer. Signed-off-by: Nitesh Narayan Lal Acked-by: Tatyana Nikolova --- drivers/infiniband/hw/irdma/hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/irdma/hw.c index 00de5ee9a260..cc165065447a 100644 --- a/drivers/infiniband/hw/irdma/hw.c +++ b/drivers/infiniband/hw/irdma/hw.c @@ -537,7 +537,7 @@ static void irdma_destroy_irq(struct irdma_pci_f *rf, struct irdma_sc_dev *dev = &rf->sc_dev; dev->irq_ops->irdma_dis_irq(dev, msix_vec->idx); - irq_set_affinity_hint(msix_vec->irq, NULL); + irq_update_affinity_hint(msix_vec->irq, NULL); free_irq(msix_vec->irq, dev_id); } @@ -1087,7 +1087,7 @@ irdma_cfg_ceq_vector(struct irdma_pci_f *rf, struct irdma_ceq *iwceq, } cpumask_clear(&msix_vec->mask); cpumask_set_cpu(msix_vec->cpu_affinity, &msix_vec->mask); - irq_set_affinity_hint(msix_vec->irq, &msix_vec->mask); + irq_update_affinity_hint(msix_vec->irq, &msix_vec->mask); if (status) { ibdev_dbg(&rf->iwdev->ibdev, "ERR: ceq irq config fail\n"); return IRDMA_ERR_CFG; -- 2.27.0