Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 4.9 12/16] net/rds: dma_map_sg is entitled to merge
 entries
To:     Pavel Machek <pavel@denx.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Santosh Shilimkar <santosh.shilimkar@oracle.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Sasha Levin <sashal@kernel.org>
References: <20210901122248.920548099@linuxfoundation.org>
 <20210901122249.305212889@linuxfoundation.org> <20210903065035.GA11871@amd>
From:   Gerd Rausch <gerd.rausch@oracle.com>
Message-ID: <a5edcbfd-7492-964d-688f-4f2a3f45e4ca@oracle.com>
Date:   Fri, 3 Sep 2021 09:02:41 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.1
In-Reply-To: <20210903065035.GA11871@amd>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?8v93ZRxyQNyx5PxzylhIopXVb4Clb56Y89swtQtFOGc5rJ8hOqZ8VJNQ?=
 =?Windows-1252?Q?UJgLMZ8JEyIFeji2/kleuaPnL0wIZTJ13KsM5C8Fw6FLNe4c3NibS/sX?=
 =?Windows-1252?Q?XdXXcZYM6MSLlA3V/udpGlRryfTFEO04M8jiV408IzjojdOMd6KnHBQZ?=
 =?Windows-1252?Q?k6wM+U52u6j7TxjfJEQxrR1A81h2a5FM+35PgLd5XrkA4xr1F16E+e+L?=
 =?Windows-1252?Q?AIQF8TnR4J1J8sMiR+eCHVv6FUqc6WFyEfxsyDrLXJ/1ToDEDtmM1Hs0?=
 =?Windows-1252?Q?rfnvg1ofun9hqt9lUOuI+7Q/P9mwtZMEDEq4DsG+sZhqB8CbvmTIJQaO?=
 =?Windows-1252?Q?cElsQSSQq2S3qK1BNZTC/U8xIkDebZ31QV9BNgt58Yq/7YmP0OFw5UyH?=
 =?Windows-1252?Q?5wdW59eqBAnEyKeojHTot0T7XJlq+/Tynv+nEP4WK2ZVPMRRJL2nGpDo?=
 =?Windows-1252?Q?VeuJffvrqb3SDvDP9wxe1/WaHFepRBMozSbS18XhMPH0sM+kZUi5NKvh?=
 =?Windows-1252?Q?L9pYJxj89BJUoDHyrSiaoClfSG9kN3sqT7A0q7wH4ZUKJMh9rZH0e5Ri?=
 =?Windows-1252?Q?fqbM+yfErlAm5K02CnLW4NFWwYflp+2ILd5pdNG5yQVoxzDTWonTsCuM?=
 =?Windows-1252?Q?MCegVeBUwN7oL3a8oXTP5+cawHQnBxjM3h5vzwPS+ZVIcqCDP1C9yz3v?=
 =?Windows-1252?Q?IfDtkETCZ4e48ZMCPkIO03SEOqVVNv+FB8YYvl+EB28CrTS/3bUtqD2A?=
 =?Windows-1252?Q?DDG23t2KfE6z7mxN51V2/pwOd+smXo9waDqs6D51sBnKtzjkJysiHUHi?=
 =?Windows-1252?Q?5EWbeyIuv45YPbITTwPSnR3r3wXc9Q1qUFIIVO8INr6zmCJgOL0dUgYn?=
 =?Windows-1252?Q?jznMOifuKvhb0saWbaPYYCoX8yC6dXvK2e8BzLB9USygaTCbZAoprzpo?=
 =?Windows-1252?Q?sO/I6q3kfsjUGlDt6MKwby0sL5LPyY+OSLH8VzM5wP2IOWe0y/C6qjOe?=
 =?Windows-1252?Q?FlcRerQPiXo/UsVtJV4osOai7Hhdl4p9J5rVMizr4jkCKZ0sqFTc32Yy?=
 =?Windows-1252?Q?lk8JSugiqpi5fbB7j7MJJ2V62Oacep41ZgOt4+f1P/CGbmHxMx4nHiqQ?=
 =?Windows-1252?Q?3Fv9XVD33WoPYJDIdFpaDNGGHVrK+OWtg9mW6RZ/AsTxrfrkPfAZ+GMq?=
 =?Windows-1252?Q?PjdsWEIVFEB48g08ux3kp/0fkROxC/4Qk2cIFcys+Ff062WH0P9CR2dH?=
 =?Windows-1252?Q?v4FHbqDGx6dqRYkca6YshsO2bgffg+z+DkRSjGxkaqD2lZBo5uk0zOgf?=
 =?Windows-1252?Q?LTHEn8omgOcUNHM3nJkSzn1i1d1BseJyIp9uI0mVCbCMQCKv8NzgaIfN?=
 =?Windows-1252?Q?MRLDEt+ialaCs5KOCJkZ0mm9OKu9kN109RmAp5j9VbPo5aGloysOCqHs?=
 =?Windows-1252?Q?nyzgoFQZcyNzxpR7UFu8bQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c785133-e3b3-4376-8add-08d96ef44615
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3158.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2021 16:02:47.8617
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bKLOVAQR5SpXu02yM0DnRGNCE/oHP/tPQz4qelBD8xiuLTfO/o6pZeKhUnV0yTIyRqgdHQ9I/Hj6e4pvMzBRCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4113
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10096 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 malwarescore=0
 mlxlogscore=999 spamscore=0 phishscore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000
 definitions=main-2109030096
X-Proofpoint-ORIG-GUID: bWIsnzbd83TwzMEpTwajjCzCb7aTd0cy
X-Proofpoint-GUID: bWIsnzbd83TwzMEpTwajjCzCb7aTd0cy
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Pavel,

On 02/09/2021 23.50, Pavel Machek wrote:
>> [ Upstream commit fb4b1373dcab086d0619c29310f0466a0b2ceb8a ]
>>
>> Function "dma_map_sg" is entitled to merge adjacent entries
>> and return a value smaller than what was passed as "nents".
>>
>> Subsequently "ib_map_mr_sg" needs to work with this value ("sg_dma_len")
>> rather than the original "nents" parameter ("sg_len").
>>
>> This old RDS bug was exposed and reliably causes kernel panics
>> (using RDMA operations "rds-stress -D") on x86_64 starting with:
>> commit c588072bba6b ("iommu/vt-d: Convert intel iommu driver to the iommu ops")
>>
>> Simply put: Linux 5.11 and later.
> 
> I see this queued for 4.19 and 5.10 where "iommu/vt-d: Convert intel
> iommu driver to the iommu ops" is not present. It may be okay for
> older kernels, too, but I wanted to double-check.
> 

It should be okay for older kernels as well.

The bug has always been there, but only started to cause panics
in cases where "dma_map_sg" actually did merge adjacent entries.

We bisected the crash down to the commit mentioned above (c588072bba6b),
on platforms that use the intel iommu.

That intel-iommu commit wasn't there on Linux-5.10 and older.
But the RDS bug was.

Hope this helps,

  Gerd