Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     bpf <bpf@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "acme@kernel.org" <acme@kernel.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "kjain@linux.ibm.com" <kjain@linux.ibm.com>,
        Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v5 bpf-next 1/3] perf: enable branch record for software
 events
Thread-Topic: [PATCH v5 bpf-next 1/3] perf: enable branch record for software
 events
Thread-Index: AQHXoBueIwYxVW5RBEGe48w8ZsQtdKuR8+oAgACTfYA=
Date:   Fri, 3 Sep 2021 16:50:34 +0000
Message-ID: <D501C4AD-3778-431B-A710-3399BFE6EE56@fb.com>
References: <20210902165706.2812867-1-songliubraving@fb.com>
 <20210902165706.2812867-2-songliubraving@fb.com>
 <YTHWoCcSgvfx24/N@hirez.programming.kicks-ass.net>
In-Reply-To: <YTHWoCcSgvfx24/N@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XqTl9SsQGnp+7oDwFIskR4+GsmwsCMsslIwoUQB1fiAe9kmYfSADYGIrJoZp?=
 =?us-ascii?Q?0Nj9KXo6cW0pQicACz05R6rYtmqwSrbSdVGjX3Emy/J8lZ/6s++UOzYjfwOA?=
 =?us-ascii?Q?ypZn1qoUFn0Ix+u/11R79K1oQ5ZtUBZiL74P1TZpCa5h//iv0P0eInVfGo2w?=
 =?us-ascii?Q?gKKpJ+0SWh27wZ1/suFktA6PE6GQK7I4LqDFsbBiqLgPDf+h4kupzn4g6azD?=
 =?us-ascii?Q?DV/lceZVJ9w0ZJRYx7lpvyRJlMej0HFQMLnGCVXHLzsqMEXPuzN28/KAvaM+?=
 =?us-ascii?Q?1EgNvYCQ6UOd976vSpsP28F5cQ5mPLZm2eclu46lP2fI9FM+4nH+yGSAD/+d?=
 =?us-ascii?Q?CQbsNcsYWWEpoX+DKoYVMozkZAfhJO7/o1cL8/bv6dvrr1V2sc8F41tv+DTe?=
 =?us-ascii?Q?9S7qhsEVhZWx/nkcHh+C82VU92WEgj84QkA5Qn2640q0I534v+fHcwVkVMuL?=
 =?us-ascii?Q?n+P0lWDqTm+xHLulqu1YMTH90qzj68FW+Tp7638YIZ1s2tm5WLYR+OUyb7es?=
 =?us-ascii?Q?oUckYzozV+rwzLriX4Oj+FL/v8crFhzhcXI8+AXMSE8VzQnFQZ82kHmsN7D6?=
 =?us-ascii?Q?x3LTNOHnvZ2ilGv0M32lHK72K8GsnlViYv6UIxgcmBbys9sw/71ArR9jJ3QZ?=
 =?us-ascii?Q?IcQXJ2vAqoiOKfgTO9nlefgyXmFH5S8s4qlRh6d+KyEX3oG+9mGop1QrV2v2?=
 =?us-ascii?Q?r2q/YeUKvE+hpSsx16uitLeJZghupnjys4v9N6TPtNqVFKcd5eqYsOn1u8Fp?=
 =?us-ascii?Q?ifRlDjvy4U6qmU+fOixlBQwN+fAclnbudjDdwORsft1SoGc8HkUfaxPHNFou?=
 =?us-ascii?Q?XgmYIN/A0A3UKztmzgMZqfQs85+8u3W5rIOCKqxEtmV8MU6n2KpNYBZCuDTY?=
 =?us-ascii?Q?6J0UMDd/CdOUn45lkvOWxcgw8qrlwXU06XUsB/SaYvtfEDr2UXNJLQ65ojVr?=
 =?us-ascii?Q?/yywGf7nKAQHOrn4VjLaIncUEopLTv8ej+HJheTYtw1Z+qyTzOmcoJ8C0dtS?=
 =?us-ascii?Q?z/Os0G7hWjZHvk6jMcVnxLwjD5letyX1MkAQ4phkBhn74DIXrYYekoUL12K8?=
 =?us-ascii?Q?KC5yUwKBzuBfaSqH6+siUmurSkIafh09Rq6HRdBe/+dkCFQQ687UXfOYtvt8?=
 =?us-ascii?Q?KQxdVGR0MusCR1tuoA4k9BL6QSRTwpG5dVT4ZL9ujkq9Z32hRYCSGPNnX+i9?=
 =?us-ascii?Q?PdDIOm6ypUtvUl2LIlv4ACeYTwbmDlxtazDiRYyrDOB6XB6FiuM3JsFlZefh?=
 =?us-ascii?Q?L8/jVMIzvlljWPeAaHtH6OpsZ6Ya8WS/twnv+nikhgu85iKCEIyxLsYgQBpK?=
 =?us-ascii?Q?0kEGWudaYxttrtc3s3nY11E2L7QKBjy+1y1lob9Af206wk6xZegqdkJalfby?=
 =?us-ascii?Q?/L53Rb4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <463E6A64A25C0E4DB52391F68DB2D734@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4132171a-beae-4c84-09dd-08d96efaf2c0
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Sep 2021 16:50:34.2091
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SGuvch/4fteNKyoGRR/ZFqP6xMcojZZtUSq6KVhNbRZoWMo10/E/Qc1i8Tq0IjgQKes/6ekcjIrtEDRKZRgZFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB5077
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: bT1Ues_uiC-ulVB9i2Hwp3d7lQPGRg1k
X-Proofpoint-ORIG-GUID: bT1Ues_uiC-ulVB9i2Hwp3d7lQPGRg1k
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-09-03_07:2021-09-03,2021-09-03 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxscore=0 malwarescore=0
 impostorscore=0 clxscore=1015 mlxlogscore=999 priorityscore=1501
 lowpriorityscore=0 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2108310000 definitions=main-2109030099
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sep 3, 2021, at 1:02 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> 
> On Thu, Sep 02, 2021 at 09:57:04AM -0700, Song Liu wrote:
>> +static int
>> +intel_pmu_snapshot_branch_stack(struct perf_branch_entry *entries, unsigned int cnt)
>> +{
>> +	struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
>> +
>> +	intel_pmu_disable_all();
>> +	intel_pmu_lbr_read();
>> +	cnt = min_t(unsigned int, cnt, x86_pmu.lbr_nr);
>> +
>> +	memcpy(entries, cpuc->lbr_entries, sizeof(struct perf_branch_entry) * cnt);
>> +	intel_pmu_enable_all(0);
>> +	return cnt;
>> +}
> 
> Would something like the below help get rid of that memcpy() ?
> 
> (compile tested only)

We can get rid of the memcpy. But we will need an extra "size" or "num_entries" 
parameter for intel_pmu_lbr_read. I can add this change in the next version. 

Thanks,
Song