Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     bpf <bpf@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "acme@kernel.org" <acme@kernel.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "kjain@linux.ibm.com" <kjain@linux.ibm.com>,
        Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v5 bpf-next 2/3] bpf: introduce helper
 bpf_get_branch_snapshot
Thread-Topic: [PATCH v5 bpf-next 2/3] bpf: introduce helper
 bpf_get_branch_snapshot
Thread-Index: AQHXoBucwnw6xFDotUqgbr6c5GY6BquR+wAAgACOhgA=
Date:   Fri, 3 Sep 2021 16:58:08 +0000
Message-ID: <3933B95E-9FFB-4A8C-8691-82AE8CD77514@fb.com>
References: <20210902165706.2812867-1-songliubraving@fb.com>
 <20210902165706.2812867-3-songliubraving@fb.com>
 <YTHcki5RLZIIGqbk@hirez.programming.kicks-ass.net>
In-Reply-To: <YTHcki5RLZIIGqbk@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TOrBUGNyQ493Px8HqvSkLUiGfjdAYiYMp0vfwSQ9GyR4NI1n+fPClUvSS7An?=
 =?us-ascii?Q?2wu9goMF+kQznEJA7+XljsJ9n/9p6JzoCYptDpaGKGD3yN/EeBky6mb0zU8K?=
 =?us-ascii?Q?MNUXq7gAj6KvLpAVSA8KzPtdLE7er+Y3okPbPUIwYx4tjL7LdGNSk5nIJUqK?=
 =?us-ascii?Q?vFrQ2p806YUcnmEbousy65KA8L7B5LinmniNSEziEuOAAA+qX5bFIuhecYsX?=
 =?us-ascii?Q?EGiI+hkUwhdxc5xCWt4eJMBcA0EU34UjxoBPYtanTpNVlh+x7fejwZulRNG4?=
 =?us-ascii?Q?YzQzGSklmvAWtZHlg7F9WjrCm/gPVf+yOL8qJoViNx6MGoVeNvfISX/XxVeQ?=
 =?us-ascii?Q?gClyeazD5koRBiQlFR3oF82bsVugqQQKMEVzWkLyugpxOPReR/j6iSUjtRN9?=
 =?us-ascii?Q?HAPNxZSeHLktsU1VSVAIeVBF3lhjKqTgCcFcOP8K2Lyc8OcYp61uuHP5hkKO?=
 =?us-ascii?Q?G2vtso/HpelRtSP62HvQ0tIYlfOMS26V8M76TOuc0C4NdEWLwfhu0V5VNBEh?=
 =?us-ascii?Q?3AYE+ydJP6hzyNz9gAZMaN2D/7BWqpuRi6KCVy2sbFdulXX8HX/Y83wwrrEb?=
 =?us-ascii?Q?vlqBiufY604goBPTkhyZxdQRA61uP1UFZbxyTrA9fc3XhUeBaqdStWKdCpFn?=
 =?us-ascii?Q?xpihvNakYuBWwNxjroqI52aR8Xx0m2nReg9MrVia5sSnkIzf3oNrAejYEtFc?=
 =?us-ascii?Q?ksbBlhaYCGFqFZrRQB2kejXruUFl5ZqjICLy1/8s5Tz8di7Adj1SJkg2DulP?=
 =?us-ascii?Q?Xc9XbciUfmIQHulnI64vT0N1iixjmTmVuEIwd8SPTzk7wXgrnXevtsbUWwDs?=
 =?us-ascii?Q?4wgm+Q0gkIak7pEXlrSdwNu7YJ9k5iM+A775bH/OjuV87IhI/9XJMVUVA/sV?=
 =?us-ascii?Q?8qK3l+lwix1NOcUgCe4wC7FrSk24V06J0nurq+Qh0py9w7p1a5Tf7YqxUEci?=
 =?us-ascii?Q?mVsEm0uJssXoOh5FZpG8kOelheevbBr6nGyE1veIdwaIwzeNQ9XHrrU0Q7X6?=
 =?us-ascii?Q?jQ6i+8u6xRwOAY9P0NzAB/BjDaQnREuvPTkm6DhZtzF/zyaEkBLkT/VSW0QC?=
 =?us-ascii?Q?5aJs6RVQUZzVMTL0PjK5oZwT5vYjEBaM+amKI6BkQ6Xy2QThfRW3WwOxkRg1?=
 =?us-ascii?Q?OrCGwgKX9VcNPmOfc5C4HTP4+vi/rHk1cz6gm6yQVi6RgsVmkZLQ3zG7MVEN?=
 =?us-ascii?Q?F/dkroKZ6s4zd3sapc5NeHdeuoADRgwcoqHD6aW/+J1Y8jRsFXto+56M1qMh?=
 =?us-ascii?Q?WH7mq/hSjSz/mu+SDx1cfvOei4pmZ6mC7dig348TOdvNit4wzV2cIWaTkxUZ?=
 =?us-ascii?Q?RKssBxHoBngP02573SLbT0EzEXu6dYv8ekHw4ukWP7UHZajaJvj0u5bbgo0F?=
 =?us-ascii?Q?gtM3WqU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7C41E9A474116749983E4FE6CC00F5E5@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6dc97563-9558-4d8e-8922-08d96efc01c0
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Sep 2021 16:58:08.8700
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: edXALkgvVgRgHCsCgjq+UyEe3shK5SrZuTDG0V3synLiUkDj44HZGmH+ON3vUOtDNG1gJwI/hvIo+Fm8PNTV/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB5078
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: VpDny3GaWG8M3MDSWMUW8eEh_YmfbXtm
X-Proofpoint-GUID: VpDny3GaWG8M3MDSWMUW8eEh_YmfbXtm
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-09-03_07:2021-09-03,2021-09-03 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 bulkscore=0
 impostorscore=0 priorityscore=1501 mlxscore=0 adultscore=0
 lowpriorityscore=0 malwarescore=0 clxscore=1015 suspectscore=0 spamscore=0
 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2108310000 definitions=main-2109030100
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sep 3, 2021, at 1:28 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> 
> On Thu, Sep 02, 2021 at 09:57:05AM -0700, Song Liu wrote:
>> +BPF_CALL_3(bpf_get_branch_snapshot, void *, buf, u32, size, u64, flags)
>> +{
>> +#ifndef CONFIG_X86
>> +	return -ENOENT;
>> +#else
>> +	static const u32 br_entry_size = sizeof(struct perf_branch_entry);
>> +	u32 entry_cnt = size / br_entry_size;
>> +
>> +	if (unlikely(flags))
>> +		return -EINVAL;
>> +
>> +	if (!buf || (size % br_entry_size != 0))
>> +		return -EINVAL;
>> +
>> +	entry_cnt = static_call(perf_snapshot_branch_stack)(buf, entry_cnt);
>> +
>> +	if (!entry_cnt)
>> +		return -ENOENT;
>> +
>> +	return entry_cnt * br_entry_size;
>> +#endif
>> +}
> 
> Do we really need that CONFIG_X86 thing? Seems rather bad practise.

The ifndef will save a few cycles on architectures that do not support
branch stack. I personally don't have very strong preference on either
way. 

Thanks,
Song