Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v5 bpf-next 2/3] bpf: introduce helper
 bpf_get_branch_snapshot
Thread-Topic: [PATCH v5 bpf-next 2/3] bpf: introduce helper
 bpf_get_branch_snapshot
Thread-Index: AQHXoBucwnw6xFDotUqgbr6c5GY6BquSAI+AgACLOAA=
Date:   Fri, 3 Sep 2021 17:06:12 +0000
Message-ID: <50D0C11D-71EF-4C82-A208-D7C73E241805@fb.com>
References: <20210902165706.2812867-1-songliubraving@fb.com>
 <20210902165706.2812867-3-songliubraving@fb.com>
 <YTHhOy1gqr44C1bI@hirez.programming.kicks-ass.net>
In-Reply-To: <YTHhOy1gqr44C1bI@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?54vrX7UffI8i0ARnmcXtXteBRilaqo2QjdPgpTMDVZltQFnLLRdkPedt1BWp?=
 =?us-ascii?Q?ZZW9AoEn42Gp1BzGG7tdJDRYszjCSbekFdsyGpIoCLp6DOEvyfS/TRuMBUYc?=
 =?us-ascii?Q?yLN7f7pf2i/KyJOiFHbNv5IZ9//Z+eR+OjDl2FcPwm7W5nWctYr5PVwVSzLP?=
 =?us-ascii?Q?Hca3Ol9uqHCmMCX5ve13NF0KjKYfBUNHD4XkuS0AtgGmmnxgifrTzk2FrbQK?=
 =?us-ascii?Q?3Zqc4b3xSGIw3s6fW5dA3fY/ABkHaQ89kWFPryOmmgHS924pQrVTYwSHjNMn?=
 =?us-ascii?Q?gycT9Mm9rxuBaLvBXtL8ua/HB/5egiPi0VdQYYSSIeJXrQ07mNHOKLxbjqHW?=
 =?us-ascii?Q?bYPu0DlBST6P3UamijRUSRlzO3QwslDA1WGl/q0X543Zc0FWjUYeN1CSVhmL?=
 =?us-ascii?Q?jsdww2VNIC4toDNOexKkR3lYE7Ld79Gq8XX7if8gwDvapXsMr5gGMT2Aa8Nf?=
 =?us-ascii?Q?zpSQkwLOArkzsMeq47u9g/KL4nox7w/Z0yjj4Rn/ZKyghGNTK/tYYggRaGNm?=
 =?us-ascii?Q?6aYDfFIOhBzTqnvnRZrXbT/lvCF6JxNxQKvSM++blNTgbxtm36L1z1MtjeT8?=
 =?us-ascii?Q?j7wNZYvgToZrTnpxN2SOEDiWAqdbqa76EjlpkPjeKJz8zsda6vUJl0QMoeDb?=
 =?us-ascii?Q?zdvrtaUMrP6P4vW9ZmFUI6UybGmf5HKWjrfQv/pezs2aWXpMhEWqNyC4FUCK?=
 =?us-ascii?Q?KP/CS200RWfecQMF11RW0b6HeQLTu2++7olw/ThetJBKuxMu9fcRcjzGwGCa?=
 =?us-ascii?Q?d7gMg3RxkxfQAvTfFWWt4v7diVoUkAfDbd35EBxZ5ISaZUsmcAZmg9grnb8F?=
 =?us-ascii?Q?MgjoazIacOgmuC+f3wfwefz5j7iVxfda5nIEPDesJRyX+JJKJKjtzMh9SzbG?=
 =?us-ascii?Q?jwr5ZMooqOc/bhh2U4UW6ZZLSHAUZkZIDiqOG00TQcPDTnqj0rkJkyHYTP75?=
 =?us-ascii?Q?xrw/6LVw72MlhcLAx5/JwZZ17pXXJXuHitH2PQD5ukxsH5mjTTngUtWT6n8z?=
 =?us-ascii?Q?57+M25c17hdjYIkWql+qOA7AVtkbGQaS23urr7UmHxLsJBSYE3MNIowNvijc?=
 =?us-ascii?Q?BxTbcafQWJBhYjmznXeDX0RUmesDSm/bmsTv9f1TJ60Lg2svfp6QhQfSv58u?=
 =?us-ascii?Q?divYenSPeXdp3sIDxram6+1gOwFSVnzAk4EFLeBJp4vEqbfn7tctMGH13GSM?=
 =?us-ascii?Q?fyuQ5a+AXvp6LuLNUJOZMRZkhVoFd4RUEJmSro/Esl4s7DZv54ySQZxe/do6?=
 =?us-ascii?Q?+geJ2ccR3HGdQQn9pHKQosRrMi2dxYJtNXMRLg89j3hcIgFEneBO10caIP6R?=
 =?us-ascii?Q?to+AT4GGgCGpPxn+MFBOWlTzerTqdNzXggVhR0XzXy63sttYxu7lz4/ZOfX5?=
 =?us-ascii?Q?cnToyDY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <580A60AD2C471742BC3E7607426A2D5C@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ec48151-64c5-4578-c64d-08d96efd2211
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Sep 2021 17:06:12.6230
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1952ytTgXpXCnHO9eDpY0gVweY7sYl9x0gvjE/gbmelzAS4kGitYPUWdcXd1M4Gv7rmtDCvL5O8UuVE5vKWoGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB5094
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: SsGivosI2PaguXgZVj8kT5RPMHGF5J2J
X-Proofpoint-ORIG-GUID: SsGivosI2PaguXgZVj8kT5RPMHGF5J2J
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-09-03_07:2021-09-03,2021-09-03 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501
 lowpriorityscore=0 impostorscore=0 phishscore=0 spamscore=0 adultscore=0
 clxscore=1015 mlxlogscore=999 suspectscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2108310000 definitions=main-2109030101
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sep 3, 2021, at 1:47 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> 
> On Thu, Sep 02, 2021 at 09:57:05AM -0700, Song Liu wrote:
>> +BPF_CALL_3(bpf_get_branch_snapshot, void *, buf, u32, size, u64, flags)
>> +{
>> +	static const u32 br_entry_size = sizeof(struct perf_branch_entry);
>> +	u32 entry_cnt = size / br_entry_size;
>> +
>> +	if (unlikely(flags))
>> +		return -EINVAL;
>> +
>> +	if (!buf || (size % br_entry_size != 0))
>> +		return -EINVAL;
>> +
>> +	entry_cnt = static_call(perf_snapshot_branch_stack)(buf, entry_cnt);
> 
> That's at least 2, possibly 3 branches just from the sanity checks, plus
> at least one from starting the BPF prog and one from calling this
> function, gets you at ~5 branch entries gone before you even do the
> snapshot thing.

Let me try to shuffle the function and get rid of some of these checks. 

> 
> Less if you're in branch-stack mode.
> 
> Can't the validator help with getting rid of the some of that?
> 
> I suppose you have to have this helper function because the JIT cannot
> emit static_call()... although in this case one could cheat and simply
> emit a call to static_call_query() and not bother with dynamic updates
> (because there aren't any).

We only JIT some key helper functions. I didn't think about that because 
current version is OK for mainstream and future hardware. I guess we 
can try JIT if it turns out some architecture needs more optimization. 

Thanks,
Song