Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 3 Sep 2021 21:56:01 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Vladimir Oltean <olteanv@gmail.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH net-next 0/3] Make the PHY library stop being so
 greedy when binding the generic PHY driver
Message-ID: <YTJ90frD66C3mVga@lunn.ch>
References: <20210902163144.GH22278@shell.armlinux.org.uk>
 <20210902171033.4byfnu3g25ptnghg@skbuf>
 <20210902175043.GK22278@shell.armlinux.org.uk>
 <20210902190507.shcdmfi3v55l2zuj@skbuf>
 <20210902200301.GM22278@shell.armlinux.org.uk>
 <20210902202124.o5lcnukdzjkbft7l@skbuf>
 <20210902202905.GN22278@shell.armlinux.org.uk>
 <20210903162253.5utsa45zy6h4v76t@skbuf>
 <YTJZj/Js+nmDTG0y@lunn.ch>
 <20210903185850.GY22278@shell.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210903185850.GY22278@shell.armlinux.org.uk>
Precedence: bulk

On Fri, Sep 03, 2021 at 07:58:50PM +0100, Russell King (Oracle) wrote:
> On Fri, Sep 03, 2021 at 07:21:19PM +0200, Andrew Lunn wrote:
> > Hi Russell
> > 
> > Do you have
> > 
> > auto brdsl
> > 
> > in your /etc/network/interfaces?
> > 
> > Looking at /lib/udev/bridge-network-interface it seems it will only do
> > hotplug of interfaces if auto is set on the bridge interface. Without
> > auto, it only does coldplug. So late appearing switch ports won't get
> > added.
> 
> I think you're looking at this:
> 
> [ "$BRIDGE_HOTPLUG" = "no" ] && exit 0
> 
> ?

No, i was meaning this bit:

   for i in $(ifquery --list --allow auto); do
        ports=$(ifquery $i | sed -n -e's/^bridge[_-]ports: //p')

Inside this is the actual adding of the interface to the bridge:

                                        brctl addif $i $port && ip link set dev $port up


$ /sbin/ifquery --list --allow auto
lo
eth0
br42

I have various tap interfaces for VMs which get added to br42 when
they appear.

     Andrew