Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 3 Sep 2021 16:30:47 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Kalesh Singh <kaleshsingh@google.com>
Cc:     surenb@google.com, hridya@google.com, gregkh@linuxfoundation.org,
        john.reitan@arm.com, orjan.eide@arm.com, mark.underwood@arm.com,
        gary.sweet@broadcom.com, stephen.mansfield@imgtec.com,
        kernel-team@android.com, Ingo Molnar <mingo@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [RESEND v2] tracing/gpu: Add imported size to gpu_mem_imported
 tracepoint
Message-ID: <20210903163047.20e4f286@gandalf.local.home>
In-Reply-To: <20210831170233.1409537-1-kaleshsingh@google.com>
References: <20210831170233.1409537-1-kaleshsingh@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 31 Aug 2021 17:02:29 +0000
Kalesh Singh <kaleshsingh@google.com> wrote:

> The existing gpu_mem_total tracepoint provides GPU drivers a uniform way
> to report the per-process and system-wide GPU memory usage. This
> tracepoint reports a single total of the GPU private allocations and the
> imported memory. [1]
> 
> To allow distinguishing GPU private vs imported memory, add an
> imported_size field to the gpu_mem_total tracepoint. GPU drivers can use
> this new field to report the per-process and global GPU-imported memory
> in a uniform way.
> 
> User space tools can detect and handle the old vs new gpu_mem_total
> format via the gpu_mem/gpu_mem_total/format file.
> 
> [1] https://lore.kernel.org/r/20200302234840.57188-1-zzyiwei@google.com/
> 
> Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
> ---
>  include/trace/events/gpu_mem.h | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
> 

This is that trace event that doesn't have any in tree callers, right? I
thought there was going to be some soon.

For the updates to the tracing side (besides not having any users), it
looks trivial to me.

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

But this needs to be pulled in by one of the GPU maintainers.

-- Steve