Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: Bug: d0e936adbd22 crashes at boot
From:   Jens Axboe <axboe@kernel.dk>
To:     Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Len Brown <lenb@kernel.org>, linux-pm@vger.kernel.org
References: <942f4041-e4e7-1b08-3301-008ab37ff5b8@kernel.dk>
 <c56cde110210bec6537fe69b495334c6c70c814e.camel@linux.intel.com>
 <3ac87893-55ba-f2d4-bb1e-382868f12d4c@kernel.dk>
 <7f115f0476618d34b24ddec772acbbd7c0c4a572.camel@linux.intel.com>
 <767fe00f-bf31-1eb0-09cc-1be91c633bb4@kernel.dk>
 <d6bf08cbfd9f29ddb8cf29f522d68efc5c676624.camel@linux.intel.com>
 <903f2e71-983f-39b8-dd0b-d697616ab63e@kernel.dk>
Message-ID: <a6041178-e7d6-4ad9-b96a-91b4702d0305@kernel.dk>
Date:   Fri, 3 Sep 2021 14:57:24 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <903f2e71-983f-39b8-dd0b-d697616ab63e@kernel.dk>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/3/21 2:41 PM, Jens Axboe wrote:
> On 9/3/21 12:00 PM, Srinivas Pandruvada wrote:
>> Hi Axobe,
>>
>> On Fri, 2021-09-03 at 09:00 -0600, Jens Axboe wrote:
>>> On 9/3/21 8:38 AM, Srinivas Pandruvada wrote:
>>>> On Fri, 2021-09-03 at 08:15 -0600, Jens Axboe wrote:
>>>>> On 9/3/21 8:13 AM, Srinivas Pandruvada wrote:
>>>>>> Hi Axboe,
>>>>>>
>>>>>> Thanks for reporting.
>>>>>> On Fri, 2021-09-03 at 07:36 -0600, Jens Axboe wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> Booting Linus's tree causes a crash on my laptop, an x1 gen9.
>>>>>>> This
>>>>>>> was
>>>>>>> a bit
>>>>>>> difficult to pin down as it crashes before the display is up,
>>>>>>> but I
>>>>>>> managed
>>>>>>> to narrow it down to:
>>>>>>>
>>>>>>> commit d0e936adbd2250cb03f2e840c6651d18edc22ace
>>>>>>> Author: Srinivas Pandruvada < 
>>>>>>> srinivas.pandruvada@linux.intel.com>
>>>>>>> Date:   Thu Aug 19 19:40:06 2021 -0700
>>>>>>>
>>>>>>>     cpufreq: intel_pstate: Process HWP Guaranteed change
>>>>>>> notification
>>>>>>>
>>>>>>> which crashes with a NULL pointer deref in
>>>>>>> notify_hwp_interrupt() -
>>>>>>>>
>>>>>>> queue_delayed_work_on().
>>>>>>>
>>>>>>> Reverting this change makes the laptop boot fine again.
>>>>>>>
>>>>>> Does this change fixes your issue?
>>>>>
>>>>> I would assume so, as it's crashing on cpudata == NULL :-)
>>>>>
>>>>> But why is it NULL? Happy to test patches, but the below doesn't
>>>>> look
>>>>> like
>>>>> a real fix and more of a work-around.
>>>>
>>
>> Please try the attached.
> 
> I'll give it a test spin right now. Please do add a Reported-by tag,
> though. That's always prudent.

And you can add Tested-by as well, it works for me.

-- 
Jens Axboe