Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp899869pxb; Fri, 3 Sep 2021 16:43:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCb7aJX2mosSxDdmhctP2Qb6GgNJvs2BqcIg9H88H5zPHcDOF8D5jDLGTxMcVclINuTklK X-Received: by 2002:a05:6e02:130e:: with SMTP id g14mr962940ilr.81.1630712627219; Fri, 03 Sep 2021 16:43:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630712627; cv=none; d=google.com; s=arc-20160816; b=KQUHxKKPjsrcMThE4uaNIm7mF/4//qkbeA/dFSDLRQxwjTeZU0xukrkXhb1LGkBJba k+VN824Wb0WZ3xtehQzIW/867jrlCcrincHaH7Ku22u+gt3ht//DCqBGoFirjS9xKsUz eQmUylQxHaU90Tlw8Au8AVE1cCZ5cW80KUHE/C6Ht2hFnFnjydEUHPFS6btTJ/uLCgnr XHd7ITz1PKS8CWZbcUuLZz8w77Yjh3Hn4F2eMjsapFEL7xgOFaOGso3VX6sWi9csB8QG 9lYrvJI/HO0vMD66EsHCm8CMLRCLsGSdobSu7O/4JN8BfWYna1X0e/KdaioFe2YFiOY2 H85g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=9VyHnrpdaAGfTsMG4jSt8uLXr2vuUSFvqiMs6Z7blZ8=; b=pvsy/J5N40tzjaMZPrcSBgr30dM5vcxUVrbPaKPw9h29hbwe/GXNUkWENWnSoGc80k lZFqLvNXXxdQzznemGxbAY0zkD2lZ2aB43QN/VTafbaJDvfEiV9g8QNitabpRQwLp7T3 LDFRj7T6B9hnpHahDVBa6KR5fdh8dRlo2OKJ5I3vFTCZbYltZoYBc6YEMKaYABZ1tEAH s8lY9sskOr0HnnzMUAdkIx4UPn54u3L/azR2JcEKwHNtYaWrc57rgSFWbl7uCLHaaDPo fHnXW0Epr/vNa+y+2nGFiwWmR528bjqcTV95FXGHli4gFMG2/Lkka13ypaIGhtn3Oii3 Mo0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=K8O0JbyT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l126si683438ioa.77.2021.09.03.16.43.22; Fri, 03 Sep 2021 16:43:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=K8O0JbyT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236816AbhICXMi (ORCPT + 99 others); Fri, 3 Sep 2021 19:12:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235894AbhICXMi (ORCPT ); Fri, 3 Sep 2021 19:12:38 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A2CEC061575 for ; Fri, 3 Sep 2021 16:11:37 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id x27so1305912lfu.5 for ; Fri, 03 Sep 2021 16:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9VyHnrpdaAGfTsMG4jSt8uLXr2vuUSFvqiMs6Z7blZ8=; b=K8O0JbyTuDEIYjIpdBNAFYJ1TzrbIUD0u7HfVjPfyHcW3tbAELblkOb4WQmzk9pKrH GWUo2VkIdrw3RVMZXvKYNuZcY9T8R8L8n6KqwN8wQBGIiTFUtpZ0BsnsYybjJ1tpErHg VylHHfaIk4Q88U1RlysxjeBFWfgUHs3oHbCvU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9VyHnrpdaAGfTsMG4jSt8uLXr2vuUSFvqiMs6Z7blZ8=; b=rJLA3zP5MDI3jXz3xPh8HXUoK0iLIdIbmyKkYuYVDlmRhM4PsEC3I8molhp5nJIDfD XsNnnz5JwUEuKmj0n1tMULJN+/QC8rF1EJQR6Jp5Ubvtj/7MWlTUQHb5lKZXoGK/NqoA ast+qqfkQh13ybnbf0dIT3ItnHE8RZf3Fp86JTYoZs5PX7IKcEwpxYplOM+cUbJt3E/D LumZjnv/8GlnscJCmi5u30hkhgmkEuZzQVeBgUxF16TwCGISP5dIH7N31y4gGM12+pZO 9Z9SQ9Pw/bbKqdiB0h2tknzOG9xqnpRzt+roIj58ohivmDj9iycHoGS7ZM+SEJROvuAO 1pLw== X-Gm-Message-State: AOAM533kVmg6KR9Of9Wq+n07Qe/LLvb3MjbysvDLwNZU7/bVD7c4nJ9r cCRQeS+yHJkZXEK5tm3nixVlR3T/A2oisS2FYng= X-Received: by 2002:a05:6512:110b:: with SMTP id l11mr908769lfg.199.1630710695219; Fri, 03 Sep 2021 16:11:35 -0700 (PDT) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com. [209.85.167.52]) by smtp.gmail.com with ESMTPSA id 10sm74672lft.233.2021.09.03.16.11.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 16:11:34 -0700 (PDT) Received: by mail-lf1-f52.google.com with SMTP id x27so1305822lfu.5 for ; Fri, 03 Sep 2021 16:11:34 -0700 (PDT) X-Received: by 2002:a05:6512:3da5:: with SMTP id k37mr919994lfv.655.1630710694461; Fri, 03 Sep 2021 16:11:34 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Fri, 3 Sep 2021 16:11:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: dozens of sysbot reports To: Eric Dumazet Cc: Eric Dumazet , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 3, 2021 at 4:08 PM Linus Torvalds wrote: > > It had just added __GFP_NOWARN to hide the fact that it did crazy > allocations and just wanted the craziest ones to fail silently. .. and yes, we can make __GFP_NOWARN limit that WARN_ON_ONCE() too, but the whole point of this really was to actually find people who simply didn't check their arguments. So I'd rather add a few sanity checks, than say "__GFP_NOWARN silences the sanity check too". Linus