Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp1195935pxb; Sat, 4 Sep 2021 03:02:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaeGOjBNCyNPId6KzkncUalxwNaY+rLXdBdyZxIDy2FnTrtm2LIKNLY6Ozqsw0CMgBWb5n X-Received: by 2002:aa7:ccd6:: with SMTP id y22mr3432520edt.363.1630749722850; Sat, 04 Sep 2021 03:02:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630749722; cv=none; d=google.com; s=arc-20160816; b=g3DsGqjoXrt6Hp+sc4bXLxJqd0IInOK6exbkR6CByTza5rFSLPwCzCMpaWUVFVwGjO wqheb7zERvMIF/mpxaylhIphY5waLTC40CkSv3rxcKN7n9J2UOlFwL2j24zk5VMelprK OEfHTMZ/lepAAu/t5Km/rahl9SXQnplgeSo+hD0ZtU1MFKbeXiwCKPAEw85WeuI+k6zu CLN4AP2luG7plZJgtMbkFBN8tZXBMUHlQ4d0Mgt5NOq+MM4iPPqRnanR+V/Za8YGOJd5 pJGaenQdZYsxWY8WIDBqm9tdnLDK0TMvZZgQoeDQ5yUbUvezeM9CxxqV/81chFy745jy smlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=FnU9rSJYZgaFBv4Z7TiWY5Ztu7bfDHyOVqaoVMK8P6M=; b=eJzZh8A522F6F9d8qMRZujzsMtA67rTQdY7AfO9KmC/dXwcvbBSp+wgeOiPVpHsaxl LKyXz1wT3VnFFyIS/poMUaFBDQGUP0Cc8BU6Px3OXv7KR9BqrHUdnXBGsYG7RnpQLO6A Gt96MbBhohuA/mH7tvHJTCNBJV8T30QtB3oOXl/75FnMEKsy6TfW0rM3QtksHbhzDT3/ Btp2KiweDv8cisSgWeQDPGvG+z/sbUGfR8g+9JOwA+P/zY7QP8y8GJSCQnKIbcb2owU4 qap623hzJ9/30/7h8y7iG4RQuXq9omBNDD8ZWdK/PzS5ys1myZxK+iQg1e+SK4EWexTA fCBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fv6PYBOZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q18si2805328edi.63.2021.09.04.03.01.38; Sat, 04 Sep 2021 03:02:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fv6PYBOZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235121AbhIDKBI (ORCPT + 99 others); Sat, 4 Sep 2021 06:01:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:45124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234618AbhIDKBH (ORCPT ); Sat, 4 Sep 2021 06:01:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id B202561056; Sat, 4 Sep 2021 10:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630749605; bh=ylmsh0vL4rvwx9sSRgSyqQInuxwwEAUGh3DY5WRrZz0=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=fv6PYBOZ09EBpaMtwC1DVgSLa8wnYcyOfc0MsaFxA1bs5eS0YSkOrtqZwmCYdtXwH a35pxxCegq+s/ba6w+T2p36fkWmpF9h1cbd2kIPgp81V9DxJ3MLA3I/tf+2tA9QXlc 0HvOeYFAJ9HZeCOwQnDu6PcV04olvwgt+1js1oe68R53Gut5HxX5GvYil9eMS4lXRT VR7NtX2qOAMdnA6dh1EEE9608McOE/RF9z62VsotGEIO9GPYCrZIUPwN4RnGfmLk0D VjoEBuVaAj+VW3iTRT5XM+I9dpj5hT3nEbUI/F7CaC1vk0WqF1RDsi27iVQ3HSj460 2CbNbwNISU9rg== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id A516460986; Sat, 4 Sep 2021 10:00:05 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom From: patchwork-bot+netdevbpf@kernel.org Message-Id: <163074960567.20299.3371264143272818975.git-patchwork-notify@kernel.org> Date: Sat, 04 Sep 2021 10:00:05 +0000 References: <20210903073543.16797-1-dinghao.liu@zju.edu.cn> In-Reply-To: <20210903073543.16797-1-dinghao.liu@zju.edu.cn> To: Dinghao Liu Cc: kjlu@umn.edu, shshaikh@marvell.com, manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, davem@davemloft.net, kuba@kernel.org, sony.chacko@qlogic.com, anirban.chakraborty@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 3 Sep 2021 15:35:43 +0800 you wrote: > Previous commit 68233c583ab4 removes the qlcnic_rom_lock() > in qlcnic_pinit_from_rom(), but remains its corresponding > unlock function, which is odd. I'm not very sure whether the > lock is missing, or the unlock is redundant. This bug is > suggested by a static analysis tool, please advise. > > Fixes: 68233c583ab4 ("qlcnic: updated reset sequence") > Signed-off-by: Dinghao Liu > > [...] Here is the summary with links: - qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom https://git.kernel.org/netdev/net/c/9ddbc2a00d7f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html