Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp1299516pxb; Sat, 4 Sep 2021 06:06:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypT4CGiXcKC2fE52umIQg0JAZKWn52U/fxK92/USQeF+TpGxZ1i1B3/1lBnf4zb/HKWenT X-Received: by 2002:a05:6402:3116:: with SMTP id dc22mr4158257edb.398.1630760764694; Sat, 04 Sep 2021 06:06:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630760764; cv=none; d=google.com; s=arc-20160816; b=Ns1bLi2PeoMAqzy1vW6sI5GNwClffMuA9UW1LhgTDlktX9pGD2ZGSLVzdVpS71s1DB xAK2CxsGeHQVkyZ+yKO69PvlBAJkkhiw5FYx6c76lnDFnzdzRt3Q+5uuyQRRQXEj1mRj OAWsIXMHoLShbKWeGIc4pLVnXA436ipCWk2h43tJQc9Sj11hfFBT94Ddgry8XbhkMsLK TxOe/tjFwwwDVJmJbvdrWxGCV5j168kjvoLK/ogY1sG97oNjNWz76UyTguQblVw2i3kt rR7OB5QQmSxHiWaUQwuFyQQpbTAAxWtC4WIxjQbviPZV1Zy4Zdg/VzcZvXpkAT4YIlkn W+vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=hWdLCsJwPXe5S+PDhMU75473QN73+wYuiuXu5T3CTIc=; b=t5mgO6QATjoEB14j1CwpwqIT4LZP2CWFSrsRd6JFrDTinY3zilTPU8RCvewHV2iqz5 DoZOVqmuom01EGioF6k5fKeO+GY2l0ZQZCplzSt1NgKaANNcHh2LAeov4erMIkO3qXyz vAmfuGtxX06HGAOF7FUujZ/Uds0s1S6pDwTE6mA1puAhy0K3p1ycukpMu5je22A5++Ru TmDwDLXEIK8EeSGulXECHThU8roRaMfBfdm888P6j19NTnwNcUnfhDOAgcVBT78yEpwc bzvRuDEGlEm8FDISizSPGAdfwMnZSSHICt1LJld/o+xxfNdyG3RHuKZlelPsJvVX85/A d7jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qesyA4Cb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x2si2674344ejy.385.2021.09.04.06.05.27; Sat, 04 Sep 2021 06:06:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qesyA4Cb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236443AbhIDMvd (ORCPT + 99 others); Sat, 4 Sep 2021 08:51:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229957AbhIDMv2 (ORCPT ); Sat, 4 Sep 2021 08:51:28 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06BB1C061575 for ; Sat, 4 Sep 2021 05:50:27 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id m17so1170270plc.6 for ; Sat, 04 Sep 2021 05:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=hWdLCsJwPXe5S+PDhMU75473QN73+wYuiuXu5T3CTIc=; b=qesyA4Cbsvrn1UJfP5GeveoMwAdqJ7Bl6Xe4QZaJoC+bSH+gjY0uDnbZNM1bYldQDX mLzolZyOcamwdGinpRkfWrN+ekTVLRhIMjaKb8fv+VtSJUtL242FDaGsH6GJIHbiGh97 dvajymDDOIzETw2aB+IrrIA5VwtIzcZZYlzfxrdMdfFwQFRQxkOQU4Z7jEMWuk0OzRIn TChRUATegYoJBYbdeasDErJhCMpBhHIMD1B/KyrkCwvBbkDcBEBT4/wONIjyfe3L7WSU LOxegMOf84uUcjhOuQV3ce67OC9BWgxiAkkUPf2qYLP5O1xR/6FxTaDDI+DwleaYmT89 IN/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=hWdLCsJwPXe5S+PDhMU75473QN73+wYuiuXu5T3CTIc=; b=Y3smVAeD5NlNNh0Uooeqs4KmWRU5tYj9pprwd12/xYouC7J8ItAdCfWm/C9AItEgYY RrY8BvGz7oD+P4klT9sdoA/OO+TXFGNmsZXTPNidY7XF9BnfRAm1xNwcppCo987Q7jZ8 G8ybzF2Ehb5TuxUeJuf42eFzTNSLijTR0H9NYiVUIYvVM1iz3PIhxG8YYUscr/f1F0ss v5Yvcjmbm63dI51VibzTrYvUxgsiVuAxAkhPUUBAAAGmA/ijdiNSfWAnDFGd0Dj3SQwI 3pDwTIw28jFN+dfBHMo/PVxqrnG0nbjxHOTT+CRI+IZlcxt0yaXaszzNWFWxQ4Va+jkY kkiQ== X-Gm-Message-State: AOAM533WfzK/xPwl8nagJYYOrOAaoRx+3ZgaSj/XJmDfH8g5wL9f0A9B lYcd3jsBW07G+HUoKknM6bs= X-Received: by 2002:a17:902:b7c8:b0:138:c28f:a775 with SMTP id v8-20020a170902b7c800b00138c28fa775mr3033168plz.11.1630759826388; Sat, 04 Sep 2021 05:50:26 -0700 (PDT) Received: from user ([117.98.200.228]) by smtp.gmail.com with ESMTPSA id x3sm690764pfu.164.2021.09.04.05.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Sep 2021 05:50:25 -0700 (PDT) Date: Sat, 4 Sep 2021 18:20:20 +0530 From: Saurav Girepunje To: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, straube.linux@gmail.com, saurav.girepunje@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com Subject: [PATCH] staging: r8188eu: core: remove condition never execute Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove condition which never get execute. as pattrib->mdata is always zero before if condition check. Signed-off-by: Saurav Girepunje --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c index 4178b3c1ff57..f314f55997bf 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE) SetToDs(fctrl); - if (pattrib->mdata) - SetMData(fctrl); - qc = (unsigned short *)(pframe + pattrib->hdrlen - 2); SetPriority(qc, tid); -- 2.32.0