Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <YTNrjG1y05ByN54+@user>
In-Reply-To: <YTNrjG1y05ByN54+@user>
From:   Phillip Potter <phil@philpotter.co.uk>
Date:   Sat, 4 Sep 2021 18:53:28 +0100
Message-ID: <CAA=Fs0ki06L55d080iUVT=HUG3boOw0zf17e8VKoBtomUHeMcg@mail.gmail.com>
Subject: Re: [PATCH] staging: r8188eu: core: remove condition never execute
To:     Saurav Girepunje <saurav.girepunje@gmail.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Greg KH <gregkh@linuxfoundation.org>,
        Michael Straube <straube.linux@gmail.com>,
        "open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        saurav.girepunje@hotmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 4 Sept 2021 at 13:50, Saurav Girepunje
<saurav.girepunje@gmail.com> wrote:
>
> Remove condition which never get execute.
> as pattrib->mdata is always zero before if condition check.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>  drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index 4178b3c1ff57..f314f55997bf 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16
>         else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)
>                 SetToDs(fctrl);
>
> -       if (pattrib->mdata)
> -               SetMData(fctrl);
> -
>         qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
>
>         SetPriority(qc, tid);
> --
> 2.32.0
>

Thanks for this.

Acked-by: Phillip Potter <phil@philpotter.co.uk>

Regards,
Phil