Date: Thu, 7 Dec 2006 14:44:23 -0800 (PST)
From: Linus Torvalds <torvalds@osdl.org>
To: Daniel Barkalow <barkalow@iabervon.org>
cc: gregkh@suse.de, Jeff Garzik <jeff@garzik.org>,
       linux-kernel@vger.kernel.org
Subject: Re: Disable INTx when enabling MSI
In-Reply-To: <Pine.LNX.4.64.0612071659010.20138@iabervon.org>
Message-ID: <Pine.LNX.4.64.0612071440480.3615@woody.osdl.org>
References: <Pine.LNX.4.64.0612071659010.20138@iabervon.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1343
Lines: 30


On Thu, 7 Dec 2006, Daniel Barkalow wrote:
>
> Jeff proposed a patch in http://lkml.org/lkml/2006/11/21/332 when Linus 
> wanted to do it in the PCI layer, but nobody seems to have told the actual 
> PCI maintainer.

I got a patch from Jeff, but it was marked as totally untested, and wasn't 
even signed-off, so I asked for that to be fixed, and never heard back.

If somebody sends me the patch that disables INTx when MSI is enabled, 
with testing, and saying "I verified that this fixed it for me", I will 
happily apply it.

NOTE: _I_ want the one that is PCI-wide. No per-driver stuff, please. I'm 
of the opinion that any hardware that supports MSI but doesn't support 
INTx_DISABLE from PCI-2.3 (or at least do it automatically and ignore the 
bit in the config word) should just not use MSI at all. Such hardware is 
simply broken (and nobody has actually pointed to an example of that 
existing in the real world, so we really most likely will never care about 
the theoretical situation about something that might react badly to 
having MSI enable automatically disable INTx).

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/