Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 5 Sep 2021 11:12:03 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     <Eugen.Hristev@microchip.com>
Cc:     <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <Nicolas.Ferre@microchip.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
        <Ludovic.Desroches@microchip.com>
Subject: Re: [PATCH v2 05/10] iio: adc: at91-sama5d2-adc: add support for
 separate end of conversion registers
Message-ID: <20210905111139.2b5ade8c@jic23-huawei>
In-Reply-To: <7d2607ce-4cfc-63f9-dad2-a5ef5c9538b5@microchip.com>
References: <20210824115441.681253-1-eugen.hristev@microchip.com>
        <20210824115441.681253-6-eugen.hristev@microchip.com>
        <7d2607ce-4cfc-63f9-dad2-a5ef5c9538b5@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 31 Aug 2021 06:45:01 +0000
<Eugen.Hristev@microchip.com> wrote:

> On 8/24/21 2:54 PM, Eugen Hristev wrote:
> > Some platforms have separated the end-of-conversion information from the
> > usual ISR/IMR/IER/IDR registers, into EOC_ISR/EOC_IMR/EOC_IER/EOC_IDR.
> > To cope with both variants, helpers are being added, that will make
> > code more clear and more easy to read.
> > 
> > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> > ---  
> 
> Hi Jonathan,
> 
> If you can still make changes on your testing branch, I noticed a typo 
> in the shortcommit of this patch : 'at91-sama5d2-adc' instead of 
> 'at91-sama5d2_adc' , grepping through commits in the future might miss 
> this patch, so maybe you can change it ?
Testing is very much rebaseable.  I won't push the tree out as something
I'm not happy to rebase until I have a stable base for it (after rc1).

So dropped v2. I'll get to v3 a bit later today probably.

Jonathan

> 
> Thanks,
> Eugen