Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210904232808.25638-1-rdunlap@infradead.org>
In-Reply-To: <20210904232808.25638-1-rdunlap@infradead.org>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Sun, 5 Sep 2021 22:41:34 +0100
Message-ID: <CA+V-a8u7NC5+2k051EP_V_HLn638X5Fzwj_UcM83ZV24qES0uQ@mail.gmail.com>
Subject: Re: [PATCH] media: i2c: ths8200 needs V4L2_ASYNC
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Ezequiel Garcia <ezequiel@collabora.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media <linux-media@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Randy,

Thank you for the patch.

On Sun, Sep 5, 2021 at 12:28 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Fix the build errors reported by the kernel test robot by
> selecting V4L2_ASYNC:
>
> mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove':
> ths8200.c:(.text+0x1ec): undefined reference to `v4l2_async_unregister_subdev'
> mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe':
> ths8200.c:(.text+0x404): undefined reference to `v4l2_async_register_subdev'
>
> Fixes: ed29f89497006 ("media: i2c: ths8200: support asynchronous probing")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Ezequiel Garcia <ezequiel@collabora.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org
> ---
>  drivers/media/i2c/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
Prabhakar

> --- linux-next-20210903.orig/drivers/media/i2c/Kconfig
> +++ linux-next-20210903/drivers/media/i2c/Kconfig
> @@ -597,6 +597,7 @@ config VIDEO_AK881X
>  config VIDEO_THS8200
>         tristate "Texas Instruments THS8200 video encoder"
>         depends on VIDEO_V4L2 && I2C
> +       select V4L2_ASYNC
>         help
>           Support for the Texas Instruments THS8200 video encoder.
>