Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210901050725.5273-1-caihuoqing@baidu.com>
In-Reply-To: <20210901050725.5273-1-caihuoqing@baidu.com>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Sun, 5 Sep 2021 22:49:06 +0100
Message-ID: <CA+V-a8sw+r_7py40021J5Snep_hChwHiBEOPKZ4Vu=6vXUJ4eQ@mail.gmail.com>
Subject: Re: [PATCH] media: am437x: Make use of the helper function devm_platform_ioremap_resource()
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media <linux-media@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Cai,

Thank you for the patch.

On Wed, Sep 1, 2021 at 6:10 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
>
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
>  drivers/media/platform/am437x/am437x-vpfe.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
Prabhakar

> diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c
> index 48bb0c93729c..2dfae9bc0bba 100644
> --- a/drivers/media/platform/am437x/am437x-vpfe.c
> +++ b/drivers/media/platform/am437x/am437x-vpfe.c
> @@ -2393,7 +2393,6 @@ static int vpfe_probe(struct platform_device *pdev)
>         struct vpfe_config *vpfe_cfg;
>         struct vpfe_device *vpfe;
>         struct vpfe_ccdc *ccdc;
> -       struct resource *res;
>         int ret;
>
>         vpfe = devm_kzalloc(&pdev->dev, sizeof(*vpfe), GFP_KERNEL);
> @@ -2411,8 +2410,7 @@ static int vpfe_probe(struct platform_device *pdev)
>         vpfe->cfg = vpfe_cfg;
>         ccdc = &vpfe->ccdc;
>
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       ccdc->ccdc_cfg.base_addr = devm_ioremap_resource(&pdev->dev, res);
> +       ccdc->ccdc_cfg.base_addr = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(ccdc->ccdc_cfg.base_addr)) {
>                 ret = PTR_ERR(ccdc->ccdc_cfg.base_addr);
>                 goto probe_out_cleanup;
> --
> 2.25.1
>