Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2414985pxb; Sun, 5 Sep 2021 18:32:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbuSd11RrrbV97ZkBlZ5U68C9XsEksLgoX++jU1ap2WgWyXHa2yey19LQRIPyTjys3vJx9 X-Received: by 2002:a50:9e41:: with SMTP id z59mr10877330ede.376.1630891971429; Sun, 05 Sep 2021 18:32:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630891971; cv=none; d=google.com; s=arc-20160816; b=xqloA1QHGhGl4JcFlNYo0CK3bwQCaSJju5bWMIQfeUwYTAv/ShF5mthq/p3fU7uTNI uWu35axzD7yul3DGwvDDQ7ChURBOaSQQJGA4iZxha0czj/v8PXUjvNb6la+tHbLhI46T UDx35xF8C9HN5tKABgBirsfn7WpHl18sjFVcrBzWGsOxP1RPojgsoCxiwBmCgfDklclN eUp7c8FXWvHlcwuh8jb2GUg5MpvUZT3ZYlZLZsaRMhiuj5zdrAwqetqFhdFM/BsVMv/e bEKLSKAtWmcnbELvKtyBNViFtZjBCEtjMZCmbmORfqt5GR0th29ZehMU/z+IQlFBd8DL IxYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=3Hvtb0CkTgZdoYxOAJolrUxcuDdtVsM6K7OtfDtwQSg=; b=FnVvDam9NaAOXxGqvzLrQGqh+aPX4HNjDyhjdoLgtMoi+fgPV4l5RFLdA3W512m/2M zrXuugrtnV07OinrM4/0i1SsfZZVb0AYpbDUgvymMUGZcPEyZtRcT1we7muxhejl23+8 NYwpRD7D6tyYpU3OIZn0LzR5TBiI4lOibTNLkGAOb+F0qIvDf/m5xZWfI7smRfOBvGep C7kf921skL6UCBh7cjm7/7Nkj7P1XDVvnqpOq71W9jR6QqzecxgstC0TzPhwBWmW+YVd d9qV6Fih33UK4rdxiLYhrvKzMxk0GYsfNub9EA9035KIaccxbCcuYSUTmYyRTvQ6n2Nb ooHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nc27si7047255ejc.640.2021.09.05.18.32.28; Sun, 05 Sep 2021 18:32:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240405AbhIFB3H (ORCPT + 99 others); Sun, 5 Sep 2021 21:29:07 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:15291 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240936AbhIFB1F (ORCPT ); Sun, 5 Sep 2021 21:27:05 -0400 Received: from dggeml756-chm.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4H2rLh2dmBz8sqg; Mon, 6 Sep 2021 09:25:32 +0800 (CST) Received: from [10.174.179.14] (10.174.179.14) by dggeml756-chm.china.huawei.com (10.1.199.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Mon, 6 Sep 2021 09:25:59 +0800 Subject: Re: [PATCH] scsi: libsas: co-locate exports with symbols To: John Garry , , CC: , , References: <1630664852-225115-1-git-send-email-john.garry@huawei.com> From: Jason Yan Message-ID: Date: Mon, 6 Sep 2021 09:25:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <1630664852-225115-1-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.14] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggeml756-chm.china.huawei.com (10.1.199.158) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ?? 2021/9/3 18:27, John Garry ะด??: > It is standard practice to co-locate export declarations with the symbol > which is being exported. Or at least in the same file - see > sas_phy_reset(). > > Modify libsas to follow this practice consistently. > > Signed-off-by: John Garry Reviewed-by: Jason Yan