Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2478683pxb; Sun, 5 Sep 2021 20:43:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZTrRvQ8sgh6AdS173Ca67uFjoVKOKjNnu27chUP3K789JzcSVXXI+3aTN4ukwYowUtEr3 X-Received: by 2002:a17:906:2dcf:: with SMTP id h15mr11470188eji.320.1630899834080; Sun, 05 Sep 2021 20:43:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630899834; cv=none; d=google.com; s=arc-20160816; b=Pc7Niunwlmv7jddBspDEkxX6OdMqJ0rR3czjaw01uI4Wn5aJF9le8izpwbY5qP9Ocu FLlopgI+KwxX0TJ5mbUse2M5yB2GQBKDs4QlBLNzmgymagttcs78f5WF83iQxbho6ot8 OxAQvHYemO8w4YCP1r319b4bmj/JRY6uQnzhSTUkbvYnfjytsOyuKYgpasmT118E+3GW TKsLfrv9cy47deqQLcqbp5RuWEcNK181PQ1RJmHjf9cWX9G2icVOeiPupuqtYOL9Pd3v 96l/78ORAaeW7HTmsn5mI1aPgmxLJOOAj8oTvvVUorHNbWywdrd2j0kGEOeR01dcLG67 fcYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=gVuz8afyJ/HunKgJw2vF5XMPhVB1a8pcL5e5aB23HhA=; b=B9BWn4Hzi3cUuL7omKfPY6JrIjAGFEQ/rvEpEbh23Z54iTeEBxGKz+QJc6HP2cVAIp QFfRJziDvWn7/3WGqrxDIP+l3lF6z5dNLPy6nwkJSWvgar2umWVYoQmKWUfKviqLB7lX ckaOB88+YQDl/5xyyR3z3JcQYNxuUvwxCJg9nS7ttv7xQcwhDBOEU4jaK0osj0hStpv6 4Z0p7QuD30yZ39+n5mr9LwySVVkVPT7kaS83BTfvnG5fzjLMQK7lo1urTYVu+IkocIup ETrY5Et7g7ZWK689RJQR5qtzO1KG+1O2VhZkNQWU+dFeGLD6KZky3qaR34DAbEskSeQl YtwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=BY+sYAKh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id go35si6253723ejc.255.2021.09.05.20.43.30; Sun, 05 Sep 2021 20:43:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=BY+sYAKh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239071AbhIFC5O (ORCPT + 99 others); Sun, 5 Sep 2021 22:57:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238842AbhIFC5N (ORCPT ); Sun, 5 Sep 2021 22:57:13 -0400 Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84A75C061575; Sun, 5 Sep 2021 19:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1630896967; bh=gVuz8afyJ/HunKgJw2vF5XMPhVB1a8pcL5e5aB23HhA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BY+sYAKh5QV2OoKud0iQ+Dva/XcEZ09UqUgKA7u7+wOiNLF7XT//xCJ0wmeEMdZnh XZGsM2V7c7aj0IwZE5krcP1sjszG9PEsoOV6CFgPB9TYxdiOqGk//LBrio+rsh0DvL VmkHObNCX8WfWISkLYxZAvqwuXHoiMVY+e1W58fj+tYlqroJd4k/2LP4eCl4rZF07M JYbFVHvxEKiOFByaoxT8YRdYrDkC+cqnHRHOsSPUrdyODg0HuzPVYs7haX1wUxEHQ+ bRgZrXAlGTbV7HXkHTOOQ8LT7ak8PNfWZl3JQdX+0N/6DxfZbzPqiIfvv9Q1YGs6dn ZEOgbhHz245eA== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4H2tMB6cqRz9sW4; Mon, 6 Sep 2021 12:56:06 +1000 (AEST) Date: Mon, 6 Sep 2021 12:56:05 +1000 From: Stephen Rothwell To: Jens Axboe Cc: Geert Uytterhoeven , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block/mq-deadline: Move dd_queued() to fix defined but not used warning Message-ID: <20210906125605.658fe211@canb.auug.org.au> In-Reply-To: References: <20210830091128.1854266-1-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/0TbvdZ.k.mzgR5pRSS1_teB"; protocol="application/pgp-signature"; micalg=pgp-sha256 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/0TbvdZ.k.mzgR5pRSS1_teB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Jens, On Thu, 2 Sep 2021 06:35:47 -0600 Jens Axboe wrote: > > On 8/30/21 3:11 AM, Geert Uytterhoeven wrote: > > If CONFIG_BLK_DEBUG_FS=3Dn: > >=20 > > block/mq-deadline.c:274:12: warning: =E2=80=98dd_queued=E2=80=99 de= fined but not used [-Wunused-function] > > 274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio= prio) > > | ^~~~~~~~~ > >=20 > > Fix this by moving dd_queued() just before the sole function that calls > > it. =20 >=20 > Applied, thanks. Can we get this to Linus ASAP as he has now made warnings fatal, so this is causing lots of build failures. --=20 Cheers, Stephen Rothwell --Sig_/0TbvdZ.k.mzgR5pRSS1_teB Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmE1g0UACgkQAVBC80lX 0GxoqQf/c+RsNXvAYNILKQnSN2h4RX5Hp1KPTrRTqtA2fIfg75H0AkkRSes12lPZ +3k4bbPJ11iELiCSTycYsDH457PjYcKAOA2/AQwy2rIsCBjvjx0w95TyaYok7Id6 bvQFxzgW0e0yHgic84UF8eGd4uM74Kl9R9n6hN9lolMaSfM+6iEVRtJ22HvfeyhF bOnv4PVAvioibwbBthL1k+wmHu9dbhGzXuNpd9UiG8K6s65rn/P1aAqonea5Jhfi xTmaRGbmsAaec2+qMbxhIaFifmQx784TCus7NGi426B0pCa/OFwM2YRsVrUsq3hY QNHk/JxwgOfot/N3uibvER/dw5jU+Q== =ePjo -----END PGP SIGNATURE----- --Sig_/0TbvdZ.k.mzgR5pRSS1_teB--