Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] block/mq-deadline: Move dd_queued() to fix defined but
 not used warning
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Geert Uytterhoeven <geert@linux-m68k.org>,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210830091128.1854266-1-geert@linux-m68k.org>
 <caf2449c-e86d-195d-3635-9be49159166a@kernel.dk>
 <20210906125605.658fe211@canb.auug.org.au>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <a0592ddf-306a-a833-785f-750a601487dd@kernel.dk>
Date:   Sun, 5 Sep 2021 21:04:17 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210906125605.658fe211@canb.auug.org.au>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/5/21 8:56 PM, Stephen Rothwell wrote:
> Hi Jens,
> 
> On Thu, 2 Sep 2021 06:35:47 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 8/30/21 3:11 AM, Geert Uytterhoeven wrote:
>>> If CONFIG_BLK_DEBUG_FS=n:
>>>
>>>     block/mq-deadline.c:274:12: warning: ‘dd_queued’ defined but not used [-Wunused-function]
>>>       274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio)
>>> 	  |            ^~~~~~~~~
>>>
>>> Fix this by moving dd_queued() just before the sole function that calls
>>> it.  
>>
>> Applied, thanks.
> 
> Can we get this to Linus ASAP as he has now made warnings fatal, so
> this is causing lots of build failures.

Sure, it's actually the only branch I haven't sent off yet today. Will
do so now.

-- 
Jens Axboe