Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2494561pxb; Sun, 5 Sep 2021 21:14:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEUjoPa7OGbQlsHL+LfiUU/0MnO1pJmtHtVhdlFM14/kZkcD2yImWAkBieLtCcLeypzhJ9 X-Received: by 2002:a05:6602:3c5:: with SMTP id g5mr8514981iov.42.1630901670073; Sun, 05 Sep 2021 21:14:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630901670; cv=none; d=google.com; s=arc-20160816; b=lG9B/vFY1y+jEmhAdBNihEmj51XakxTJgFlkf9+2IwWSbZf77i3ZGLA+602qn0RhBl XjeJI8iU5BcJB+YATbi85u+hCCXb5kvP+uTrs5PPgOH5Je1uqqvS+nv6hH8e9wAlUpLD GZZ3qzObd7ePkYyRthn5VMvfadyNaVzIOhXSctBvL9zMBWbUwUEtO8eurUGK3gaf9Uuk Exnwk2P9BTTql//HaVpy3gMXUnb2f+19ioCKv/Ssdv++x8kr4BgVJ5bUCiylRDgceV/C A2q56lwnG4VrZZgmxQXSButUZLG1h9BlOoa8fw/F51aL945lKoB/GzddzIgvDnmM0p+h TW1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=aMyOs5KURw0ylNVRy7PWd+JnRcqnOEgyA7dtb08/Cp8=; b=ogm2SQHAniKVdZWuabY2Xr+LJu2UCHlmIjcK0qWykk1gsvlOuKMsQsjkELrf7lOIkZ AE9c9+xF0m6taue75asVJBSMuEg4AE4k6SiqM+iHu4+ocaXbeoeSr0siQJlg8qpnM/2w etGeqy1RjblR+8MtcDJyJA+KnGV3aEEDedDpuCuMmRWzk4aVZ0CBNj8+Q0b9dxohRjHA jXupyCU9otzmB64rxyqTLmuCv40RQyOGZVCzVdYbKB39bSGWGaEJ/IF/jagL9WuqHFIF /E57tdGp2O2qvZgTVuhUaHLCSFzdTsINH0Za2RKPXoTAnL50AOTnyBOG0YfCUFDOI7pM A8nQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=A9+QKld1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j24si6719628jaa.10.2021.09.05.21.14.18; Sun, 05 Sep 2021 21:14:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=A9+QKld1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230191AbhIFEOa (ORCPT + 99 others); Mon, 6 Sep 2021 00:14:30 -0400 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:53324 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbhIFEOZ (ORCPT ); Mon, 6 Sep 2021 00:14:25 -0400 Received: from localhost.localdomain (1-171-98-108.dynamic-ip.hinet.net [1.171.98.108]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 960BE3F245; Mon, 6 Sep 2021 04:13:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1630901600; bh=aMyOs5KURw0ylNVRy7PWd+JnRcqnOEgyA7dtb08/Cp8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=A9+QKld1uCsIVfE7kIQEAjCKwCAcUwjJDbK3EbExPWjfmsCRIExsEelE/4zdclKm0 i8KI9qBJciphkEf51w/7R7pmpXagbetc0v6He5jfaT9PMQW3rVUpIULhp4sLQZ1TuR CeBh+uNtY3U8BTptq4kRy9O5II2KUkqnUu0a3DeFYiRR7pXIyyXLh/MQkHNFo/AY+P sPqlQ7mLVLE/owlv+LPt4PM2SBh4Lhh26q+TjeG/aBmyTCXPP+HKCmrxvK9fUhg7/+ ptTLbLxKsWP8KzrpqHBszkYLshGvswsJoECAT2xbIWkWRgv9yL2QMz6GFAlyV6Z+fh JJFJ4FHm8YZ/A== From: Kai-Heng Feng To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com Cc: Kai-Heng Feng , David Airlie , Daniel Vetter , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Lucas De Marchi , Imre Deak , Uma Shankar , Matt Roper , Kai Vehmanen , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/i915/audio: Use BIOS provided value for RKL HDA link Date: Mon, 6 Sep 2021 12:12:59 +0800 Message-Id: <20210906041300.508458-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 989634fb49ad ("drm/i915/audio: set HDA link parameters in driver") makes HDMI audio on Lenovo P350 disappear. So in addition to TGL, extend the logic to RKL to use BIOS provided value to fix the regression. Fixes: 989634fb49ad ("drm/i915/audio: set HDA link parameters in driver") Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_audio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c index 532237588511..4e0f96bf6158 100644 --- a/drivers/gpu/drm/i915/display/intel_audio.c +++ b/drivers/gpu/drm/i915/display/intel_audio.c @@ -1308,8 +1308,9 @@ static void i915_audio_component_init(struct drm_i915_private *dev_priv) else aud_freq = aud_freq_init; - /* use BIOS provided value for TGL unless it is a known bad value */ - if (IS_TIGERLAKE(dev_priv) && aud_freq_init != AUD_FREQ_TGL_BROKEN) + /* use BIOS provided value for TGL and RKL unless it is a known bad value */ + if ((IS_TIGERLAKE(dev_priv) || IS_ROCKETLAKE(dev_priv)) && + aud_freq_init != AUD_FREQ_TGL_BROKEN) aud_freq = aud_freq_init; drm_dbg_kms(&dev_priv->drm, "use AUD_FREQ_CNTRL of 0x%x (init value 0x%x)\n", -- 2.32.0