Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2555822pxb; Sun, 5 Sep 2021 23:14:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/bHYoahVbIsysEn3Mv5xStERkk4E9hYjcDDEtPYEeGKAfgFGTQYf1JWsB2/3dfeDRIAuo X-Received: by 2002:a05:6602:20ce:: with SMTP id 14mr8355879ioz.204.1630908848451; Sun, 05 Sep 2021 23:14:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630908848; cv=none; d=google.com; s=arc-20160816; b=slMw5IhVQ/B1K3bNQ2JNDYU33gjcx5UJdOtAdlzErahbXhewy9V0ZECre1RVUDi0Ag e8bovo6fN1D19LG1zwO5Zj5ouVi1tVyjpMVkZ0JhMBqlzmfzzZ5flD9EZVjChaUj+HsZ hnsD5AXLff+Mz+Dyw3yiOL+mJjPTVZqp+dRCwoHvNzUKOG/1TrBaA1M5ilKX9WMhJAg9 7szHPPiJXBQ6eq7+zd6dZDvmsoS2eNP20XUyYuhVnX9qsb75CtODC52pkUyskTQu1ArT 7p2iTCsMN0i6TUWj3VAZ5sPXmyyQsOMflnBXKRkS7Y9g2qGLNzNNMpCL2DvezA79GSLy fAqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-signature; bh=IW2wXTx3q9w67ADlEVFXdIL/3i+IwIgYXJEPTjHUFLE=; b=B3D2aQXncPwzUCQgAf2Ds5dlx+2wbJJVumatVt7vYCgneszImRXjmpAo+iKCXuVDK+ cGNkQsc19zdiFvwrF3/FBU140i8IJlFqFZddnxhIfO8j4JhCMppevmei4SabV6Za7BZG 4Jb8mZSr5ZGY2n8KDCesEEeB/BQjHB38ViMbsXCmFS69yiBNV2OE8tk1ekYs27M3Qi9r A3WLK/HCfok0DG3WJ0ekJ9uKs0wE+FA4Ure1jjhg+Hh93HbJuPUt9hrljfiyQzKwE0vN gbiElreTl/Xyxj8XWyA/2K+AgVdBwA/1T1CxALWPXUgxPxmY44RjxA6LIgCrzwO1JVtT cMYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=cdu5Kcxe; dkim=neutral (no key) header.i=@suse.de header.b=Haxu3h4F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v1si6467874ile.137.2021.09.05.23.13.56; Sun, 05 Sep 2021 23:14:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=cdu5Kcxe; dkim=neutral (no key) header.i=@suse.de header.b=Haxu3h4F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239356AbhIFGOG (ORCPT + 99 others); Mon, 6 Sep 2021 02:14:06 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:51802 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231271AbhIFGOG (ORCPT ); Mon, 6 Sep 2021 02:14:06 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6DBEA2007A; Mon, 6 Sep 2021 06:13:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1630908780; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IW2wXTx3q9w67ADlEVFXdIL/3i+IwIgYXJEPTjHUFLE=; b=cdu5Kcxe5T45mIwBh0hw5uWrJPqfhaqUy5AHnSDVpWr1VK0bTyeuKnb89d220mhGRehvQW WgVnj92lYOZLF1AnZwORbLX3ndF3hIZDm6+JpSQAsQrIiN2KtbNFQE+CpuJYDhxwP8JLlN yAYZwubaK7d4XijvWC+NBBJgEaO76CQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1630908780; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IW2wXTx3q9w67ADlEVFXdIL/3i+IwIgYXJEPTjHUFLE=; b=Haxu3h4FqB2gptSDa9nivWLj+aYZ7FbLfzRJIqR39E3EULT0+f8Kcko3XuIE76ycB1eNXX XqOcs6STyIW2LQBg== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id C1BE713299; Mon, 6 Sep 2021 06:12:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id EQ1rLGixNWGdTgAAGKfGzw (envelope-from ); Mon, 06 Sep 2021 06:12:56 +0000 Subject: Re: [PATCH v3 1/8] scsi/sd: add error handling support for add_disk() To: Luis Chamberlain , axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com, kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com, beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com, swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com, josef@toxicpanda.com Cc: hch@infradead.org, bvanassche@acm.org, ming.lei@redhat.com, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org, dm-devel@redhat.com, nbd@other.debian.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig References: <20210830212538.148729-1-mcgrof@kernel.org> <20210830212538.148729-2-mcgrof@kernel.org> From: Hannes Reinecke Message-ID: <10e3756d-09fb-7c5b-83d8-b1c527880b6c@suse.de> Date: Mon, 6 Sep 2021 08:13:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210830212538.148729-2-mcgrof@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/30/21 11:25 PM, Luis Chamberlain wrote: > We never checked for errors on add_disk() as this function > returned void. Now that this is fixed, use the shiny new > error handling. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Luis Chamberlain > --- > drivers/scsi/sd.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer