Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2556326pxb; Sun, 5 Sep 2021 23:15:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwKZnxnNpyLp7FpI0Rmad1qXZqmNUj57v5gmB5Vdni9KKcITEeZk9+ElBtRLw7Jqkr0KTu X-Received: by 2002:a02:c055:: with SMTP id u21mr9574422jam.113.1630908902540; Sun, 05 Sep 2021 23:15:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630908902; cv=none; d=google.com; s=arc-20160816; b=qKMBQ1ew8GxZVk8gYguwBZ+NwroBbelEXYDwjy+gmbKepYsoOS7MD1Hoe7MfHWrKhg qGveCIWhLMgHKBqc3nOS98HXa9stTXAxiEQnubDSB5D6h09Phz1gQqfTbPNtIjKgHEZu 0gWAFuecdCgw0+McawIdDjstNDbyPagDEa+u2X8GNfqul2L8wsgLafziSJnV11lOjosE IWd77JTDix2CNmRPpU9hdK9OzRPFZ5xfrCRA2+ZzBo8xTL40tJ8WHuEuu8+PSpXNqrAW AMH7u9gPH9vLUmc3dBJOmWG1R8OXH9Rk1SyyqI02/mPuH8xQck/Pc0SVNdqDZuLtq7TC crRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-signature; bh=lspn4kTqfo1l+UEtf4Egkt0be/N8Ml77bfdiqmTef88=; b=smOEsXNdwaoptMT1kbcxKWDHBBg1ajJwPUnFBSkTCdkz/n+rzfYdIie/CVFGKELpF8 njDyMVu+Rt46s+9GZDgqgmRuasxhpTPkfx9bLJ7MK7Ff7xo5giCPrnXiwi57Fn1VV4wO udXNpoqYFZLhxv3Ow3WNKZax2TZh9YQhj29Md4Ctag1JT4M+jPirC9qFY/inX6qlt2nj eoKzpD6dDGusrFb/Nt/iE59DUkF+0XtB064XzLXrhMG/M7v/9NyaahY9RUNxO4eq9fO4 niJnhdH40s/+PU6ohPPSv+2AuqpBiaAqBVUoXwMHs1PxMVJtONwdESNLFRz3H/BW3jG7 KAug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Z7kAUAko; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i62si6183332iof.83.2021.09.05.23.14.51; Sun, 05 Sep 2021 23:15:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Z7kAUAko; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239665AbhIFGOp (ORCPT + 99 others); Mon, 6 Sep 2021 02:14:45 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:51890 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239231AbhIFGOk (ORCPT ); Mon, 6 Sep 2021 02:14:40 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0F2ED20086; Mon, 6 Sep 2021 06:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1630908815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lspn4kTqfo1l+UEtf4Egkt0be/N8Ml77bfdiqmTef88=; b=Z7kAUAkoUoVqKUucQvGBbnne9RRYQb+877TVVUDYFlXLBj1vd2K6aEYj8O7WegcEvA+rAW triorv/pklm8/0LJmUL6zTdEhyiD2l1EDkCZGZyJn0j1qKjnoS0y8Jo0jX6UdXHvHdNGgW NUua9pi49OO9Tdn5znoETfAgzvUdf70= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1630908815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lspn4kTqfo1l+UEtf4Egkt0be/N8Ml77bfdiqmTef88=; b=hLOiAHDIAS7+slwD/a6rYPlZQ8urmL226wpnzqRp17MgWRgfPhhPZFIs7yN9RLxrncR8z1 rnp0/BnhHQnKdUAw== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 87DF013299; Mon, 6 Sep 2021 06:13:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id ujk+II6xNWG+TgAAGKfGzw (envelope-from ); Mon, 06 Sep 2021 06:13:34 +0000 Subject: Re: [PATCH v3 2/8] scsi/sr: add error handling support for add_disk() To: Luis Chamberlain , axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com, kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com, beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com, swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com, josef@toxicpanda.com Cc: hch@infradead.org, bvanassche@acm.org, ming.lei@redhat.com, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org, dm-devel@redhat.com, nbd@other.debian.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig References: <20210830212538.148729-1-mcgrof@kernel.org> <20210830212538.148729-3-mcgrof@kernel.org> From: Hannes Reinecke Message-ID: Date: Mon, 6 Sep 2021 08:13:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210830212538.148729-3-mcgrof@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/30/21 11:25 PM, Luis Chamberlain wrote: > We never checked for errors on add_disk() as this function > returned void. Now that this is fixed, use the shiny new > error handling. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Luis Chamberlain > --- > drivers/scsi/sr.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer