Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2566432pxb; Sun, 5 Sep 2021 23:34:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxjghTYwHSr9SXT1GUHv/Iai/QHNJkfP5jsW85iBjKzwanSWVTK7+KeB7kcLNzebcsgJzB X-Received: by 2002:a5d:9ac1:: with SMTP id x1mr8634327ion.191.1630910093249; Sun, 05 Sep 2021 23:34:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630910093; cv=none; d=google.com; s=arc-20160816; b=yufQXbwXy8m5cYjmurXYoxFxQU88hy3Ltp2aHTra0c1pZTjSX4SCkMbsiTwyIAoais RDRrKhYnvjT2e9uOBIon4utsP8cHxvii1gI8EVCQUnND4+9ncA+NCurDJliQgZvUi6FS 3yrVqFYiTiW4dddPN8V48pxycBrVwOspTsR0mW+JlX9d/89ap+MB51iEXbSoU1YJRDIa WhWMaiH9YeqQ/K4RWCx6paKmH00CAMCM7mWuxIev5zAu3eiXuHFZKkKC9K5szF9kCw70 jdFO03C/qtnJn1CzsKR8R8XBbom9nRh0R88fAwqOpVRAUpqEs/pXNifYpREI97VIuedy bJ2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-signature; bh=Ey7lpaW6fvpR3/j8rd1yAmZ1YpH4O35hvNfgLdJlM6Y=; b=Gf1YAT/a5cDm+oRAEaasNZ7r2Yb75vsgNAADeWtydsRL5ly+7Z0QRCxYv9kFF6vCVN 6zIn0VFjBuJs3VQX4aO2f+24p3eABU2LLeJso75x6gS3KU9oQvnhYU0Ev8fUbFbK30EB KfktoRdP5SuAtJL4y5EdQZZ4G0H4hIhPd45MZefnuBrjnuTiR5xLeb7FTrQl6MJhLtnO 9Ud54ILTa9gSefeMR0RGt07MaES5vYn7WIli0d5FuiPw+m0+ABjFO2XoK9az80kAjV6h vGSFPcKN1XNFk2fZpw+zkDefCXtvhlvO+a/pQ7Ej1u3D/vGrIA8tOba+I34QLR+Xj1ZZ U1yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=DixJoh3X; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w17si4963694jad.70.2021.09.05.23.34.41; Sun, 05 Sep 2021 23:34:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=DixJoh3X; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239490AbhIFGUg (ORCPT + 99 others); Mon, 6 Sep 2021 02:20:36 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:41810 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231271AbhIFGUf (ORCPT ); Mon, 6 Sep 2021 02:20:35 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 072DC220F3; Mon, 6 Sep 2021 06:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1630909170; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ey7lpaW6fvpR3/j8rd1yAmZ1YpH4O35hvNfgLdJlM6Y=; b=DixJoh3XE0j7jlmKZxZwgKeRN5Oo9Jl30NJ1a2Wjhj5G4w3lcYs0djv7wOJquiwI9YjW+A AyHAk7Ap+WkAzlUK8GwYGZtBlEDKQ1t7khU/Xnms6NPQCa8GBdTOx+AGWPolkexCOG5Vd9 Z3FLqfdGBF2MLBE1jxfuUdD7xpNgOT0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1630909170; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ey7lpaW6fvpR3/j8rd1yAmZ1YpH4O35hvNfgLdJlM6Y=; b=1gncyHDzT+otaETlCzLKqGBKWt9Gy7JhU4EqqlvPduGwM2DIDR1MwtRYJF5c2T2h8RVei8 ky/EK3RdKqL5+qDQ== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 5FEBE13299; Mon, 6 Sep 2021 06:19:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id n4IVFfCyNWG0TwAAGKfGzw (envelope-from ); Mon, 06 Sep 2021 06:19:28 +0000 Subject: Re: [PATCH v3 7/8] loop: add error handling support for add_disk() To: Luis Chamberlain , axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com, kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com, beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com, swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com, josef@toxicpanda.com Cc: hch@infradead.org, bvanassche@acm.org, ming.lei@redhat.com, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org, dm-devel@redhat.com, nbd@other.debian.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig References: <20210830212538.148729-1-mcgrof@kernel.org> <20210830212538.148729-8-mcgrof@kernel.org> From: Hannes Reinecke Message-ID: Date: Mon, 6 Sep 2021 08:19:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210830212538.148729-8-mcgrof@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/30/21 11:25 PM, Luis Chamberlain wrote: > We never checked for errors on add_disk() as this function > returned void. Now that this is fixed, use the shiny new > error handling. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Luis Chamberlain > --- > drivers/block/loop.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer