Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2574218pxb; Sun, 5 Sep 2021 23:51:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGgztwFNDCVMholOrnC2//1xLvv44UGb0YTGE5y+av+Zud/n2KBtcTzGTuhhZ7xRuCJS5c X-Received: by 2002:a17:907:2151:: with SMTP id rk17mr11800318ejb.41.1630911061354; Sun, 05 Sep 2021 23:51:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630911061; cv=none; d=google.com; s=arc-20160816; b=imq+FZLm+RJWFsRZ5kO/IJHBa0KhgG1XHGKNMAgKZQagU+JkEVZKZcuiq9MxgEqcyF 1iuzVDZ1rekii0WT85ucV+hGsrgV2l9UrKQC9liZLQqunLsuRSlJdIUsT1KTiffK22Ol vPICQfaxONfXZ5pDVisAtb2Jc7T8e3j9oRhq2kt6APlrP5W5Th0Idj+8m+2Wm0Eksrjv kuzxse+c9aqY2vt7P7yGcJl912t9XOeh724NfVXWc806noiE34324zDzGrHObb4e8GPI XSxAjOzEKW4f8/wt8vvssXrmXzsCWOUos9IF0T1DqgnBo99IDrQLtE7WMa3TbaU88vMM kNjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-signature; bh=WnsfEm24FiY97oUuBVkQpzIL/MgLM8SuyHc8JYLAsNY=; b=jpDxN6h194uC+AerqFqt+1kCiqUbc648YnCASm+uKdfiPelGXJmRwqFm7ACA6iSCJ4 GVc6vvt81h1Fo+UkXOCxXGoJTV7FX/oWXY1sgkfSF7dC1zBEZX4Wci2GWqlvxTHVZY1n Cr8f8ID2BPzq6+rKMBeJlXWCerssn5MVFWRtOhE75cKfrjdWLokfn56+80cJvH67A54+ iI0JvmBDVoDsvSG73MLzp9pMQ3qoeVS2pkF9Vt+NweknvriaoSR76XhRZoWVNS84muOS BOOa5ejc3MVM+nUzkq+M2qC2uFQgEqLV+cVMGn8HdslztzJ/P4r8sHww3SGYmd4sSVH/ z3iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=G6amEv4A; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b="oO5/PbjM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i2si8212837ejw.120.2021.09.05.23.50.38; Sun, 05 Sep 2021 23:51:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=G6amEv4A; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b="oO5/PbjM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239526AbhIFGVI (ORCPT + 99 others); Mon, 6 Sep 2021 02:21:08 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:52496 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231271AbhIFGVH (ORCPT ); Mon, 6 Sep 2021 02:21:07 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E9D1220081; Mon, 6 Sep 2021 06:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1630909201; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WnsfEm24FiY97oUuBVkQpzIL/MgLM8SuyHc8JYLAsNY=; b=G6amEv4Aay3hAY1inpj2Md8h3+uttQfDibLAnOOGzrFy7lJFDkhx0sztzAGTNR4GVkCW3K F+pHfwSAtaz0uYFnubD+DSFHs9IZ0gkxYd+inQcBdPn4wIAycTdrdrccikfoGrKbpQwYZZ LJHWr1hWGeoIjmdFG8aMhkRuEhvPVkA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1630909201; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WnsfEm24FiY97oUuBVkQpzIL/MgLM8SuyHc8JYLAsNY=; b=oO5/PbjMxF/qs8tYulSXPGwu3sVi3uFKYQ3zil56qMsvk3vDb3FfUXHhz6Js3n0SXvqvlr rHuRJBcLLrpd09Ag== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 1A4BB13299; Mon, 6 Sep 2021 06:20:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id u9eHAxGzNWHKTwAAGKfGzw (envelope-from ); Mon, 06 Sep 2021 06:20:01 +0000 Subject: Re: [PATCH v3 8/8] nbd: add error handling support for add_disk() To: Luis Chamberlain , axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com, kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com, beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com, swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com, josef@toxicpanda.com Cc: hch@infradead.org, bvanassche@acm.org, ming.lei@redhat.com, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org, dm-devel@redhat.com, nbd@other.debian.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig References: <20210830212538.148729-1-mcgrof@kernel.org> <20210830212538.148729-9-mcgrof@kernel.org> From: Hannes Reinecke Message-ID: Date: Mon, 6 Sep 2021 08:20:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210830212538.148729-9-mcgrof@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/30/21 11:25 PM, Luis Chamberlain wrote: > We never checked for errors on add_disk() as this function > returned void. Now that this is fixed, use the shiny new > error handling. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Luis Chamberlain > --- > drivers/block/nbd.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer