Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 6 Sep 2021 10:32:19 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Alakesh Haloi <alakesh.haloi@gmail.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Pavel Skripkin <paskripkin@gmail.com>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: staging: media: atomisp: fix return value
Message-ID: <20210906073219.GF1957@kadam>
References: <20210903200658.GA552296@ip-172-31-53-182.us-west-2.compute.internal>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210903200658.GA552296@ip-172-31-53-182.us-west-2.compute.internal>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+gh2dNuhuTvf57yeqwdItWjqvoGWTFl3GidgKkVzj6bRatru0ouos7bW5P9j?=
 =?us-ascii?Q?5YVRTPqnM1E1TVZcW/w9VaDaqRZL0Zd6ARB+xiR+sDFnzBgRBZzBty/IpxzD?=
 =?us-ascii?Q?6M8J3arYnt9nobnYXG9r3qi7rfy+XnXpVAixLYO83y30JV/s0AdQ0/X/vzgv?=
 =?us-ascii?Q?s9ww8QEM0eXi7XctJOCfbLZxrkFW2wQPGXESGAhw7bODZ/cy6fwgRCmMjhe/?=
 =?us-ascii?Q?E8gekKHWWHNJDLCGW/zIL5gU2p88oZwufi6X8Jo+seHZ3YXOi0q3dttlQ+KD?=
 =?us-ascii?Q?lP5txv4Cp41qTohicCibqGSuZV6XyVLOj9NDO7z+rK5dtnv8nea2LCtzBWIF?=
 =?us-ascii?Q?kB7jiLqA2lzzs8RI6paezo+7WnZzUIpHfYJW5NVFGSrUoqoukFBWW2x5x79l?=
 =?us-ascii?Q?gjVCWNwvzGjETVcYWK6e1y3HsqBPJOQBNIxN3cHT/EDtMabC+cDAmOmjpBk2?=
 =?us-ascii?Q?Gd7w8DRiPQieo12ShXQRuwQMObH3AE338okKBNRYps3rCaiLUKE/dBYf1/Ue?=
 =?us-ascii?Q?7cPTRN2dcZR3W11zeGvP2cAZRWiznKb9+m2Jmf4bjRR768XEsYyKT0u1u5G8?=
 =?us-ascii?Q?bRUrrirlur3r/+3LH3+oJEWghP2xVRxcWdvoPsheEUiwW+8CisN086XXT9e2?=
 =?us-ascii?Q?gBVsz2q0wGMZ9iBsn7k9Oal0c1qDGuR23WNqx7Lvtb7Ap34Y9xmmVS40Pjcz?=
 =?us-ascii?Q?z+6uJaP36lXvSJha5ofEw1V5Z981tJ6YZpPSX5567Dh8hmk/HsJ56/WLqkmk?=
 =?us-ascii?Q?g5HneArZP1CkXfgKYB3j1p6KYoXZtS5gW4PAUnYSMkFDJUkjrPrdnH4wHDLg?=
 =?us-ascii?Q?KshDFXUiWxv4orO5h+78TNiuJfOq2yJaW5m7jLd8OUgp6msfIAq/s6Lu7ruQ?=
 =?us-ascii?Q?QagjcV89EsheZ0PVRSbep4cPxa8UmRr/lO76bSd/ZrWUhmN1GOxAmfZpMD5k?=
 =?us-ascii?Q?Iwz0LbeuCNcnHlJhkeHXwttQPaoHbNQz+7YGZr1BWOFXC9ZC6FrkfcrV/Xow?=
 =?us-ascii?Q?NweUxCGP+yhXDFm6GjRaZl6kt4fQlPQNWEWIYFT8jHG+mEUoyHyCZLp7CH6K?=
 =?us-ascii?Q?EKw6Ga128jGg7gecc2cSqeq3qJuYakZCnTWcju+jSlRybVfFJzOeNufFh0ko?=
 =?us-ascii?Q?wzQ7sfwjGOTFTxrC3Gw/KgfadGARk0FcSlO1Uim9mI0ydRdI9HHknAaV+ZC7?=
 =?us-ascii?Q?oC2G/XrQLvBxqRsKWwrBULVIXzubYFgBMPzFrlmvUrVKTXSZrzVTIdXjxefq?=
 =?us-ascii?Q?jNNTXjIiDZv3gP/p2H7aaxWXMNlQWVLXASx5P5J4EJ8Sx3ZEocLjJMER4+zn?=
 =?us-ascii?Q?1zV6bgBfEa2cn7RwEuZnO6Er?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa675d17-64dd-47e3-e2f1-08d9710881d6
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 07:32:40.4574
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: st87vw43qjvLC+FNY4v19M+cnBqHrvj0fTUwMXC0eGIQPPamHczvV1Hf0LP5bPrsMJL4btFYuHyug+OaHhJb9qKishnh5BtnflaIqahXQmk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2096
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10098 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 mlxscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2108310000 definitions=main-2109060047
X-Proofpoint-GUID: pUyWpCEOLGbtTxUbWUqHV2p-neUJO4xj
X-Proofpoint-ORIG-GUID: pUyWpCEOLGbtTxUbWUqHV2p-neUJO4xj
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 03, 2021 at 08:06:58PM +0000, Alakesh Haloi wrote:
> This fixes following error seen during module build
> error: control reaches end of non-void function [-Werror=return-type]
> 
> Signed-off-by: Alakesh Haloi <alakesh.haloi@gmail.com>
> ---
>  .../media/atomisp/pci/hive_isp_css_common/host/input_system.c    | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> index 8e085dda0c18..5d088d6fb01f 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> @@ -1646,6 +1646,7 @@ static input_system_err_t input_system_configure_channel_sensor(
>  	default:
>  		return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
>  	}
> +	return status;


You're working against a very old tree.  This was fixed over a month
ago.

>  }

regards,
dan carpenter