Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210831083223.65797-1-weijunji@bytedance.com>
In-Reply-To: <20210831083223.65797-1-weijunji@bytedance.com>
From:   Zhu Yanjun <zyjzyj2000@gmail.com>
Date:   Mon, 6 Sep 2021 15:21:48 +0800
Message-ID: <CAD=hENcbvs3_Mu7tjTPfrj8h1xTDb03y-5bACU3cckOpmPJveg@mail.gmail.com>
Subject: Re: [PATCH] RDMA/rxe: Fix wrong port_cap_flags
To:     Junji Wei <weijunji@bytedance.com>
Cc:     Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>,
        RDMA mailing list <linux-rdma@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, xieyongji@bytedance.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Aug 31, 2021 at 4:32 PM Junji Wei <weijunji@bytedance.com> wrote:
>
> The port->attr.port_cap_flags should be set to enum
> ib_port_capability_mask_bits in ib_mad.h,
> not RDMA_CORE_CAP_PROT_ROCE_UDP_ENCAP.
>
> Signed-off-by: Junji Wei <weijunji@bytedance.com>
> ---
>  drivers/infiniband/sw/rxe/rxe_param.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_param.h b/drivers/infiniband/sw/rxe/rxe_param.h
> index 742e6ec93686..b5a70cbe94aa 100644
> --- a/drivers/infiniband/sw/rxe/rxe_param.h
> +++ b/drivers/infiniband/sw/rxe/rxe_param.h
> @@ -113,7 +113,7 @@ enum rxe_device_param {
>  /* default/initial rxe port parameters */
>  enum rxe_port_param {
>         RXE_PORT_GID_TBL_LEN            = 1024,
> -       RXE_PORT_PORT_CAP_FLAGS         = RDMA_CORE_CAP_PROT_ROCE_UDP_ENCAP,
> +       RXE_PORT_PORT_CAP_FLAGS         = IB_PORT_CM_SUP,

RXE_PORT_PORT_CAP_FLAGS         = IB_PORT_CM_SUP |
RDMA_CORE_CAP_PROT_ROCE_UDP_ENCAP,

Is it better?

Zhu Yanjun

>         RXE_PORT_MAX_MSG_SZ             = 0x800000,
>         RXE_PORT_BAD_PKEY_CNTR          = 0,
>         RXE_PORT_QKEY_VIOL_CNTR         = 0,
> --
> 2.30.1 (Apple Git-130)
>