Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2619505pxb; Mon, 6 Sep 2021 01:10:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxJg/uBzujuugoZ1rB7m0TP6H8QMhKrHsHyfNakwODzc9WlIFOFLdwrY/8WkJFBdAlZHF9 X-Received: by 2002:a17:907:8309:: with SMTP id mq9mr12254413ejc.561.1630915858684; Mon, 06 Sep 2021 01:10:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630915858; cv=none; d=google.com; s=arc-20160816; b=Wf80/6QEmDpY65Fyt0l6T4YKYBh31Z9uvCNOTrxKXcKnpAHgh5YYgjYdyY/T1yDLKi r20JG9XU9yPesAM7s6IeBSM5bvdpCYuQ0pnRiOqhFrSPomC2IHAA3rGYU1D9nLmojHid bHEqEQcaiKd9pweed9N8J29y25z0aC/DCa0x6jfcsHoHbt0m5gub+L4kwsFOlty3v0Cf 8Nzse7OvH/NETWClCDv4y2edh31ZrR4k+mVVL3leY9gr5XfYY+mzbAiDk3S+Z4nEiBM1 8GA9L1BicTL0HIVKZ6FVi18rT8E1P/L3stVUaA8ToMZfcBQOMPkxKjj+9e/B6l0WT6dY SkMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=AhGWp7kK+wQk/iMtwZK8f04llYS2tzV7PC33yAIKXEA=; b=IcuSFh3HUqV5Ek1L577mmoh3QJpkEP8NI3XWpC3ZrHdGZ9sMwQhecWuxynDSpfBsLF qG0n3bcZmjg6xvaa4PwPbeBC18q1N0epmisjMbym0ICTnqO7Be5hc6MOTBUiPLFrouZs uRofE104qQ2hUf5eYxSLAf2Qc1QRZOFgHouHYf3aApl7Qg/0ZUmDIFqCaVCKy55YzoWy SJ6EtKBSQ1wUF65AKLja/DBDGJnFdqF5T1QgwHWKEuGgheQ8N1lkltaLWsSNj6WWjM8B KmP1jeEA6melV1n0WRly9miQViOARJiA73xtkqCjYMLAe4H1Xs2/KazUw3B3+MD1dJBW 41fw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d19si7257959edz.503.2021.09.06.01.10.35; Mon, 06 Sep 2021 01:10:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240578AbhIFIKS (ORCPT + 99 others); Mon, 6 Sep 2021 04:10:18 -0400 Received: from verein.lst.de ([213.95.11.211]:60533 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240406AbhIFIKS (ORCPT ); Mon, 6 Sep 2021 04:10:18 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id E18B767373; Mon, 6 Sep 2021 10:09:08 +0200 (CEST) Date: Mon, 6 Sep 2021 10:09:08 +0200 From: Christoph Hellwig To: Hannes Reinecke Cc: Luis Chamberlain , axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com, kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com, beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com, swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com, josef@toxicpanda.com, hch@infradead.org, bvanassche@acm.org, ming.lei@redhat.com, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org, dm-devel@redhat.com, nbd@other.debian.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v3 3/8] nvme: add error handling support for add_disk() Message-ID: <20210906080908.GA25575@lst.de> References: <20210830212538.148729-1-mcgrof@kernel.org> <20210830212538.148729-4-mcgrof@kernel.org> <677ca876-b003-d3b5-9e2e-d50ebef82cce@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <677ca876-b003-d3b5-9e2e-d50ebef82cce@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 06, 2021 at 08:16:35AM +0200, Hannes Reinecke wrote: > I would rather turn this around, and call 'nvme_put_ctrl()' after removing > the namespace from the list. But it's probably more a style issue, come to > think of it. The order in the patch is the inverse of the order before the failure, which generally is the right thing to do.