Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2641524pxb; Mon, 6 Sep 2021 01:49:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7V6Mxo3Jzs7PXsFRTiHyPvGjDqwfEJNOaWCm2TV/YWcxDfYBuxmTaOMGe1bcDLcQ2jRqx X-Received: by 2002:a6b:f904:: with SMTP id j4mr9072333iog.208.1630918183303; Mon, 06 Sep 2021 01:49:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630918183; cv=none; d=google.com; s=arc-20160816; b=DY3ObNwo2hAIeufaZwEpZaKIPlW5rlm7uiBFqI14Pl845Dzq4BHcRE7apjqA7eqt3h EJYEgjshnDXTzUnis1PLhKjSabDjQSn6DiGR6k5VA/2QjNvlKbBNv1KPmErtWC2z16Xr yOYus7ZRNBXAOfXqBnUJz38sycDomD9UqPk115b97l5OnfntVde5ndv/MJ+qGSCJyB+1 LPYBJ9Qz3p/xY/t4P16TFxvaEPsXOCExq7A+OyIEh0cXZLYI+mLGYf/j+NMgJJy25kne SmAGPNK9sYbAQJppgkGea7Z6opT9SLnIjlnnDaO4VyzrzwbPU8NlrgYpSjsGc510S77W tICA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oOFV3aBUUEEGyqvLAa8hfq+cLKEmGeypv5PDL5XSJEM=; b=PGGt9eZrHi8/PK+gw5WX5xlzVf+DNp+C0ZLky2oVo7AlmPVaSl3vnbNdynDgc8Vjo+ l8FbxywanENdliub53PaCsMiqWk95xPfu3Xc8VkKjryVOCK1g0OQW9SAs5nkkixcrjKb yl/ipn2nK2nPcX8o/UlCfgpDXzGwDdxJCFovw9TOw6NaNtpMKpx1e6NweEyJWiRQyU/Q lIpyOuPQ599IDwf0xzE4Cws0JodL2GF80BRvTp/GipHnmMEmz/poXnMtEVRIYZivapDh WknCuBbi70j2mZ2jZzWSwT55Esp67bAI7nl4cz3HJrnZdbaP1Cl4SdCas4ohCZrSRkvs 7IWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=by6aIIKk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x6si8147451ilu.80.2021.09.06.01.49.32; Mon, 06 Sep 2021 01:49:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=by6aIIKk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240329AbhIFIAR (ORCPT + 99 others); Mon, 6 Sep 2021 04:00:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240206AbhIFIAQ (ORCPT ); Mon, 6 Sep 2021 04:00:16 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E2AEC061575 for ; Mon, 6 Sep 2021 00:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oOFV3aBUUEEGyqvLAa8hfq+cLKEmGeypv5PDL5XSJEM=; b=by6aIIKk03uvjCAvjPQuiYUlYE q8jRCXMRztEBoYU6O426ssAa9KcZpWfL7ER69FBal0pENP/9S9hiDu1+3L/9gxeSdo9RZ3u94P8DZ 7NUGUe/KKYoWXIosJyAtBybX/FhZrMPjtKeXMVWUHfzIUqN/HGjdu5jv7b7cvb5aSXzkLlQBLPifT NkFw9vOu94tiT8ASL57JcFX0gxW3bL6BQtG0+GsbC/qP8ADfRhm9Q8PHxGg+WjML1lYHahFPsAdRu BmAxQbpLkqEOS56c5hRngdiN87/7M6je6BTpnu4erJAHpeNJqePeIjCwZAOPyYogPvlvAkQesFON1 QtAzB9sg==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mN9WG-006kn5-7B; Mon, 06 Sep 2021 07:58:29 +0000 Date: Mon, 6 Sep 2021 08:58:20 +0100 From: Christoph Hellwig To: Daniel Wagner Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v1] nvme-tcp: enable linger socket option on shutdown Message-ID: References: <20210903121757.140357-1-dwagner@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210903121757.140357-1-dwagner@suse.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 03, 2021 at 02:17:57PM +0200, Daniel Wagner wrote: > When the no linger is set, the networking stack sends FIN followed by > RST immediately when shutting down the socket. By enabling linger when > shutting down we have a proper shutdown sequence on the wire. > > Signed-off-by: Daniel Wagner > --- > The current shutdown sequence on the wire is a bit harsh and > doesn't let the remote host to react. I suppose we should > introduce a short (how long?) linger pause when shutting down > the connection. Thoughs? Why? I'm not really a TCP expert, but why is this different from say iSCSI or NBD?