Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 6 Sep 2021 09:38:19 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     Jaewon Kim <jaewon31.kim@samsung.com>
Cc:     minchan@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, ytk.lee@samsung.com,
        jaewon31.kim@gmail.com
Subject: Re: [PATCH] zram_drv: allow reclaim on bio_alloc
Message-ID: <YTXTe3U8RrvSAynl@infradead.org>
References: <CGME20210906052847epcas1p1f53f1ad04ad785d53f64eef150969c34@epcas1p1.samsung.com>
 <20210906052926.6007-1-jaewon31.kim@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210906052926.6007-1-jaewon31.kim@samsung.com>
Precedence: bulk

On Mon, Sep 06, 2021 at 02:29:26PM +0900, Jaewon Kim wrote:
> The read_from_bdev_async is not called on atomic context. So GFP_NOIO is
> available rather than GFP_ATOMIC. If there were reclaimable pages with
> GFP_NOIO, we can avoid allocation failure and page fault failure.
> 
> Reported-by: Yong-Taek Lee <ytk.lee@samsung.com>
> Signed-off-by: Jaewon Kim <jaewon31.kim@samsung.com>
> ---
>  drivers/block/zram/zram_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index fcaf2750f68f..53be528a39a2 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -587,7 +587,7 @@ static int read_from_bdev_async(struct zram *zram, struct bio_vec *bvec,
>  {
>  	struct bio *bio;
>  
> -	bio = bio_alloc(GFP_ATOMIC, 1);
> +	bio = bio_alloc(GFP_NOIO|__GFP_HIGHMEM, 1);

Passing __GFP_HIGHMEM to bio_alloc does not make any sense whatsoever.