Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2733658pxb;
        Mon, 6 Sep 2021 04:18:08 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwxjF//106ECeJOeydflIhmoZikJlLkTiNact31oXGQQACvjwugY6rr84L8w4FbQN9H1U0R
X-Received: by 2002:a05:6638:2216:: with SMTP id l22mr10498744jas.39.1630927088282;
        Mon, 06 Sep 2021 04:18:08 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1630927088; cv=none;
        d=google.com; s=arc-20160816;
        b=RC+81f5X7Mtw/5FCZIdZHxuGcOUhudbmyRnB2gO16RAybOADceU6uVmvgDT4TFkhU5
         qjPwhsh2XVIqeKWgZcISiakaRp0rrWBSPuQNX3JXU2tfxt/PRhH3/5aJBJNN3fFJPpsd
         9rcGIrTIQ8nuxZ4VRoI/bdNqYRQnYwAcKwWvVxxy7Z3ic0NONxtc7HwZj8sIOr3lDLuY
         Nqtj3vp2iIhxKAYplD6bF29x0M2A9YV8yjJO/cEbkwlrKZ69ZRKxxhh+XMHabCaTW1ks
         vUSRMD48OSRNJjtbHhrFmfjBnPq6e6UdNDpVIPdGq/f9zIxdbqOoNdmoqPa4yuhErXAy
         IMvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:message-id:date:references
         :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from;
        bh=E0uFqclNYcUVYj+dZyKRYswnxSvqbQn7Y2J+XQiuzew=;
        b=BsMXFKfHrMpyh8NswHYi81IX1k7r3nnMN1E/JY5amLjj1Zq0KXCDaudZljSTE2Yn5M
         OQBsepoRh7DN5zmpG3pfn9oGvx2LDFN1U4k+cIhGGS/7RPQQqDv8S7Ej9j7SZSmb3NIk
         gb7+YShjUngVXCwy7wR/pjy4t1kTuphBFdU46jbcUbo5PwuXeOuGaZkGqiKF4Cke0YUH
         oDymOle0yauzWRt4BY0M7hBTdw8CWiJDoG/MA1E2IPKOfsN0q5rJn3fSP1uFpVSUrC1r
         yrXfzEqc8wfCYmGTQES52aiMHCfPnubTMOp4gSStOfzgSWf+xWcKRX3CNMpPpCHatfnU
         NtYw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linutronix.de header.s=2020 header.b=HH2WSCxz;
       dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=xMCNKp43;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id h14si6795485ile.129.2021.09.06.04.17.52;
        Mon, 06 Sep 2021 04:18:08 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linutronix.de header.s=2020 header.b=HH2WSCxz;
       dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=xMCNKp43;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S241673AbhIFJvN (ORCPT <rfc822;liuwu.linux@gmail.com>
        + 99 others); Mon, 6 Sep 2021 05:51:13 -0400
Received: from Galois.linutronix.de ([193.142.43.55]:36108 "EHLO
        galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S241675AbhIFJvK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Sep 2021 05:51:10 -0400
From:   Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020; t=1630921805;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=E0uFqclNYcUVYj+dZyKRYswnxSvqbQn7Y2J+XQiuzew=;
        b=HH2WSCxznwzEkeEOhE7rzEZ2pGtoYGARF9SULB6sR5WjDr4BqZdWBTJcAWVqXuEiBrvBpN
        ibQGOLfzVGszZkawEr7xFWgliAZsXNopTrlCUMJJ62GPLgzp9Xwc5JpSM2D6OIsYXAbY77
        Sz0ssc4WTxS3r5TAHvl9KHe5Vk47hW+Z1lqkRdA5lJUtuZY0OesZnpwz4/QxYPHEEzUUmf
        R2X+gVSD35rVaUVwmfUoxHxyutAFBxNH6XsFBHLnIQSv7otfnJx/+ApZd87Aa4uuy/yCxc
        ALmrX+rT+9L+8wv4kRs0rIZMMHJP6md+T1E9XjWWBy0uvHtPhXGlbnVkYvQq+w==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020e; t=1630921805;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=E0uFqclNYcUVYj+dZyKRYswnxSvqbQn7Y2J+XQiuzew=;
        b=xMCNKp437XOsJ7iw/ape3yFXVVNaS+uRTg/It5heHqUS4ZrtcEX5/OCw6Rv1K32FXzeAII
        To/WR470XYoORrCw==
To:     Hao Peng <flyingpenghao@gmail.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/irq: Make irq_set_affinity_hint return the real
 return value
In-Reply-To: <CAPm50aL9trE88p59KFj-UfEKMji5Ouyjtk=eq55JnSzGZ12WsQ@mail.gmail.com>
References: <CAPm50aL9trE88p59KFj-UfEKMji5Ouyjtk=eq55JnSzGZ12WsQ@mail.gmail.com>
Date:   Mon, 06 Sep 2021 11:50:05 +0200
Message-ID: <87bl569goi.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 06 2021 at 16:20, Hao Peng wrote:
> irq_set_affinity_hint does not return the return value of
> __irq_set_affinity, which makes the state of functions dependent
> on the return value of irq_set_affinity_hint inconsistent.

No, it does not. The affinity hint has been installed even in the case
that __irq_set_affinity() fails.

Setting the affinity in that function is a best effort operation without
any guarantees and in hindsight this should have never been added to
this function.

Thanks,

        tglx