Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2787198pxb; Mon, 6 Sep 2021 05:28:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeTkNA2uC66Nlp3MiW0euPLN1lpJZzuKT8AwqpE5Hj4nEB25lAt+RbejKNLfdCn2OOIioV X-Received: by 2002:a05:6402:4247:: with SMTP id g7mr13012283edb.287.1630931313899; Mon, 06 Sep 2021 05:28:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630931313; cv=none; d=google.com; s=arc-20160816; b=CWdbld30ODLPh+EZl4ZYHPmRNnPl46gDWvdIcrxc5lFUW0Vx16UGZTZ3bAR4M+5Qsd pNoqhPbu9Vgw3DOA6D0Z/zaKzFYNeIJzkt9o/Yuecce9vLnhYesJFwFJMA+0xw4SJNJe je16bhrFeg1mlC6o1L4fg4fwiWblO2x7s81jqy5ER/9vpjlEMf+9HiFtZJR3QlROKm9+ gKzUY73sjm53mchpV4XppWni3AJzTNk2CguJ5257wI9VoN4QUr2FlFoRmlJGtv7RSGIR NSRtgXtRldoDIyDBb7se2StAkmsF9dQd1jQrKghmVxBgoH6/ibxBfghSMtpp6XvG2y9Y i6Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=LHNPMDIZNOuQa8v0lk7S8yV4mXPYlMq93HmuLKo1Mdk=; b=yFcB6y/hMaVAzbNi2aXrCOlUZfrXkWj2Wb378O1+xFA+u2XFEuq7pH5tARUjBI6fHL guwlFxttNlsdPk1sZT0k35tJFRmjozM8RPB1RLK500HEbu9u4qr/YiPwckw9I6tm/91E Vx5f9fulLvONpkCgCvQ48MiNllgHMZR5DlUCF10DYe+hhovDdNB8GrVAKrdBwsu+CPnZ BK3CMzI4GTiPCAA/yhbuHa364MRySGYdKK+6g7nCkBvZZ0Op41DQwP9j4eQmEsXPKG48 5tfI7fDIXhijfC3iQAJYw9AKqi++LbYQiWauHKFL58VxolzdCVHgdB8K4sgGPIow2xO3 spmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 26si8948328ejk.661.2021.09.06.05.28.10; Mon, 06 Sep 2021 05:28:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241881AbhIFMNJ (ORCPT + 99 others); Mon, 6 Sep 2021 08:13:09 -0400 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:46061 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241751AbhIFMNI (ORCPT ); Mon, 6 Sep 2021 08:13:08 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=rongwei.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0UnRyn5B_1630930321; Received: from localhost.localdomain(mailfrom:rongwei.wang@linux.alibaba.com fp:SMTPD_---0UnRyn5B_1630930321) by smtp.aliyun-inc.com(127.0.0.1); Mon, 06 Sep 2021 20:12:02 +0800 From: Rongwei Wang To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, cfijalkovich@google.com, song@kernel.org, william.kucharski@oracle.com, hughd@google.com Subject: [PATCH 0/2] mm, thp: fix file-backed THP race in collapse_file Date: Mon, 6 Sep 2021 20:11:58 +0800 Message-Id: <20210906121200.57905-1-rongwei.wang@linux.alibaba.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, We found two bugs related to file-backed THP in our cases, recently. The two bugs rough description as following: 1) in truncate_inode_pages_range, subpage(s) of file-backed THP can be revealed by find_get_entry. 2) 'collapse_file' miss the pages which in writeback but no private. This situation will be triggered in XFS when block size is set to PAGESIZE. These two patchs mainly fix the above mentioned bugs, and have been tested in latest branch. Rongwei Wang (2): mm, thp: check page mapping when truncating page cache mm, thp: bail out early in collapse_file for writeback page mm/filemap.c | 7 ++++++- mm/khugepaged.c | 3 ++- mm/truncate.c | 17 ++++++++++++++++- 3 files changed, 24 insertions(+), 3 deletions(-) -- 1.8.3.1