Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: [PATCH 1/1] scripts/checkpatch.pl: remove warning for
 pritk_deferred also
Reply-To: maninder1.s@samsung.com
Sender: Maninder Singh <maninder1.s@samsung.com>
From:   Maninder Singh <maninder1.s@samsung.com>
To:     "apw@canonical.com" <apw@canonical.com>,
        "joe@perches.com" <joe@perches.com>,
        "dwaipayanray1@gmail.com" <dwaipayanray1@gmail.com>,
        "lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        AMIT SAHRAWAT <a.sahrawat@samsung.com>,
        Vaneet Narang <v.narang@samsung.com>
In-Reply-To: <1629786900-4644-1-git-send-email-maninder1.s@samsung.com>
Message-ID: <20210906124109epcms5p88026ef667efae06506f03e61868a7996@epcms5p8>
Date:   Mon, 06 Sep 2021 18:11:09 +0530
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <1629786900-4644-1-git-send-email-maninder1.s@samsung.com>
        <CGME20210824063513epcas5p46ba8b375c3e32fab210640a28041efb6@epcms5p8>
Precedence: bulk

Hi,

Any comments?
 
>WARNING: Possible unnecessary KERN_ALERT
>+printk_deferred(KERN_ALERT "checking deferred\n");
> 
>total: 0 errors, 1 warnings, 20 lines checked
> 
>Thus removing warning for printk_deferred also.
> 
>Signed-off-by: Vaneet Narang <v.narang@samsung.com>
>Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
>diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>index 161ce7fe5d1e..e3bea0d36c10 100755
>--- a/scripts/checkpatch.pl
>+++ b/scripts/checkpatch.pl
>@@ -6252,7 +6252,7 @@ sub process {
>                 }
> 
> # check for logging functions with KERN_<LEVEL>
>-                if ($line !~ /printk(?:_ratelimited|_once)?\s*\(/ &&
>+                if ($line !~ /printk(?:_ratelimited|_once|_deferred)?\s*\(/ &&
>                     $line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) {
>                         my $level = $1;
>                         if (WARN("UNNECESSARY_KERN_LEVEL",
>--