Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2844218pxb; Mon, 6 Sep 2021 06:40:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyv0Hxo8VSOmct3AwYtGIDY8X8uoTPx8LOzqiRCtYyeHfQNQ0pO2SKL1ng+V52b12IRaF3p X-Received: by 2002:a6b:8b4b:: with SMTP id n72mr9360638iod.18.1630935603306; Mon, 06 Sep 2021 06:40:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630935603; cv=none; d=google.com; s=arc-20160816; b=X2JoW3NxG0FZUMB8+28d71t1PddxDFbnv6atvT857m9TqoqQKC667khcCFR3RwWybF kQfXFcGHts9s6g9QcKVKMeXDqBFjPVN5lBqlpwx58mVOganQ33ygZrckxc+J0rvI5HBz hSH04xMEnYKgSWzzfzXmpat/tOC9sV5W6rcQn2VEb9x7nOTjA1YVT3+cN7kjLvD0mjND TyOOMkluD02c3PsvCg46y4lKWc1sxR9vbT3TlX8v1Jd9C0tQXr5zGTvAMtBx9zg0T5xi ySeZBJXNtbxlRkXj+FQ0BGXxL8g6PoSes7kYuU68bWxy7XyCZqlQDadR/aeqV9Q/1a1P mnUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=23qGHJsatjdyHYiC+VBRXJbw6KI1C4pketSO8CQ+Ddg=; b=syWaENywxrc5cp0YQnYOST02SqsCfjpXPaEWWy68cFJqYD+pj3fFwghqP6dBHGsaKL KyMbzWkSIX0oogMi5URlOfCA1P83uOiHId9cwVhaHkQYUlUd616dBMfgE8tXIUADTJrz tP4Ow5NLUuMsoLDY4F77/92SIr+T4USEOcWpAtxUw1FZn0CJmAmWJM+wK4xLCgxb7mTw XWLRcBm5ouSuLEDfdrwFu/Zx1vD7c6Xd9z/yLVbpW7LUnc2HWmeDePsVQ0ty82ikeABc Jqgj8L/F4wZ5jOhXLPkRWPdHE3HSSbZQnH4KrInowDCUiiA/tMZ1vDYMm1Ob6NnbPaAx pPEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=itERQJFW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a7si7158545ilr.103.2021.09.06.06.39.51; Mon, 06 Sep 2021 06:40:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=itERQJFW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243905AbhIFNAr (ORCPT + 99 others); Mon, 6 Sep 2021 09:00:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:36656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243498AbhIFM7n (ORCPT ); Mon, 6 Sep 2021 08:59:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D4DFE61076; Mon, 6 Sep 2021 12:58:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630933119; bh=3+eCbje3fW8UTEA3knV/RI8TVK4lmKHcXv9hEXGbr98=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=itERQJFWlYVDYhqFIy2uKyrhxKor5hOG6UxwXcjfFeMyNrA4MFrudKYA+73l9lMDE hNjGM9paQvP70czS04f6WYY61r2K904YmbuT8qUXeOtyjRdtBfHCj8Eup6YymKAmoR Ov5nois44r0i+GaacSboGYB4j2y6jqZgecRU3PtQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zubin Mithra , Guenter Roeck , Takashi Iwai Subject: [PATCH 5.14 12/14] ALSA: pcm: fix divide error in snd_pcm_lib_ioctl Date: Mon, 6 Sep 2021 14:55:58 +0200 Message-Id: <20210906125448.596897554@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210906125448.160263393@linuxfoundation.org> References: <20210906125448.160263393@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zubin Mithra commit f3eef46f0518a2b32ca1244015820c35a22cfe4a upstream. Syzkaller reported a divide error in snd_pcm_lib_ioctl. fifo_size is of type snd_pcm_uframes_t(unsigned long). If frame_size is 0x100000000, the error occurs. Fixes: a9960e6a293e ("ALSA: pcm: fix fifo_size frame calculation") Signed-off-by: Zubin Mithra Reviewed-by: Guenter Roeck Cc: Link: https://lore.kernel.org/r/20210827153735.789452-1-zsm@chromium.org Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/core/pcm_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/core/pcm_lib.c +++ b/sound/core/pcm_lib.c @@ -1746,7 +1746,7 @@ static int snd_pcm_lib_ioctl_fifo_size(s channels = params_channels(params); frame_size = snd_pcm_format_size(format, channels); if (frame_size > 0) - params->fifo_size /= (unsigned)frame_size; + params->fifo_size /= frame_size; } return 0; }