Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2856624pxb; Mon, 6 Sep 2021 06:56:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDdCjp95A7RuSB23JGhfTFjsCitHP0hY417kRFKx8kOj0SHo/fI1WsUCYYx4EbmFkOy7+d X-Received: by 2002:a5e:c00a:: with SMTP id u10mr9681634iol.60.1630936580034; Mon, 06 Sep 2021 06:56:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630936580; cv=none; d=google.com; s=arc-20160816; b=FjwwZfKEQO4UIgDlKe0d/kZvoKjAIDWnSLwQIQzEdue0o9FqYtGwiJfhJsYbirsCXO 9xwurpLZjUXMfCrPTLb3TYA1jsjDQPfXHA17S9w/2KnuHlHanaJrlL0NWZ5SegpDb/4r VLy4I2FUFOgZeFHEBd+1xubzjbXy3G0S9PR13Y7v77Xob75T6AWnkx6cLxnw4BFv0t1G U+hkJY3NNS6u4Kk8I9n/1VrPxBfbZfanxE4TU6oceawcm77TnoSWCSaJ0N1aL6JbhRzc 8txmNQhvGuL0elKCrQSnPBAFV37nTT4/wKWdbXSwx+/UzwnAIX22xMpfwFEYI/M3HaFl Fhxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kFugvE/ynZNF5n/ZXcZgPLBJsGxghWh8Uzi5MIiuS80=; b=x7iOlBFJHQ672856CrwuTBnfy6rqM0nB2oSeBlag1nLuQQfDw7Yiwk84uTbfikAGRt k5Nbw5T8NlgocFxQU2wMzMme6+AhEd8VG86hIoHcWerCFkX6uV+RfszO8DE0yvv+sbNS Kv5GK6zeuTuNIoQExmZD43QVT9FFyTvAob3C5tFHLx5I2qnwdDEgJ75t7AYdksjB6g4i OXbDAgN/5lTdlkQIXovb7kslonCvKklb+HhaRgSj48n7FxhHcyulkXxgq0pBoNPwz8T8 mcb8JBrFsQnJbzKwjat4IWf1WvA2BU6ZKnWY+lgcP8+SwQNWAdxvqnvBiaJBMdO5JupL Gifw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=vyLoVfng; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p14si9067958iov.81.2021.09.06.06.56.08; Mon, 06 Sep 2021 06:56:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=vyLoVfng; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243012AbhIFNvF (ORCPT + 99 others); Mon, 6 Sep 2021 09:51:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:35470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242989AbhIFNvD (ORCPT ); Mon, 6 Sep 2021 09:51:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1BE9460F45; Mon, 6 Sep 2021 13:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630936198; bh=Oc0yRowwr2RWee7fH/21myDQmy8r5h2obyPq+HeSit4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vyLoVfngKqby7thz3HaOVnMDYjeOXL42SWskDM2NxdueE96KEmVagJXtx2SVUJKH9 08IgYI5VNGhbPGBoXGmCoG9kukJP79sDEGYmGw7dSGn4ZFYshCVNdH4CePSDzLn7J1 L3f33c4Cs+UA6NLiO0Kd+NQ1rUlklOwVUK3k37tw= Date: Mon, 6 Sep 2021 15:49:56 +0200 From: Greg KH To: Saurav Girepunje Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com Subject: Re: [PATCH] staging: r8188eu: core: remove duplicate structure. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 05, 2021 at 04:33:10PM +0530, Saurav Girepunje wrote: > Remove duplicate structure mlme_handler and action_handler. Both > structure are having same member. Replace it with mlme_action_handler. Why merge both names together? Why not just pick one name and stick with that if they really do the same thing? thanks, greg k-h