Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2939814pxb; Mon, 6 Sep 2021 08:39:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwF3WDxgC3xZwluOpFVXp8YFTk82eyYxtXktnowfRFfi0/fsq741t2oTfDkodxrCErlacF/ X-Received: by 2002:a5e:c802:: with SMTP id y2mr10252747iol.162.1630942750188; Mon, 06 Sep 2021 08:39:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630942750; cv=none; d=google.com; s=arc-20160816; b=UeidTV5Jl3+2s+NHSyKiqlIyYulrDiDgg1Ayk61lOqtYWSDmbDYv8fmNGoTohVsz3r I0wc0isvx3miuqkbEu5JuemxofjgBNo48Y1HwPReuMhGKOKDHWGU/SuCEgFHpYitRU1X fihV8O1ptY9QrPi0tUV0DRw4iCo8vPy/dMiZ9NiIt+L3/Zmdpaq/HLaG+W+K7krF1dbZ AmUkHhPWgyC0gNQRAryXH/z0135SlQMJMgfvy1OuLag4J5g00KTwFPpM7d1Xkcau1gX4 ojvsnXuZVP5JCWNeWK35wLArve6LKUDzdpKYzm0yxm7PRf4hsSJRgnKWsAJr47PTKhIb jUiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=CtHiP+D7k5znLaPfpOQWBuuhn0SZQDsGXEHIILBBc1E=; b=yXXv8V8mVc11hcqeNGWNHCQTxgaDl3PQBwxl2VE/mOqu6Y42bZESIVPAvnvqt4TZ1n VQWAwtuRbplYuW/3cKM9pm1SfV2UXULFKWtte9eZK25y9T66l1tYBphpQGiNXsPBz/es Jnt9Hu5qGz+RPBnI1lQDOM1Z8/lNJNbpOOKFG3MgIOFXnM0HhyejSitg3drgJm9ZtB40 XoQzhDrrqg4Iy2S4yIzpcN15zHsOpZN9o2VKwjzepZxUswOkhyOJ0viIszGwWM3Ks2kC 4P+4lwQjNdqz5DgmFJ1NiHQOINFKt2xcwr7Sv/dVYOvOb19XPBbrRb1Oek6M7G4qjd3v If7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=WCfNNygV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p5si8678651ilc.89.2021.09.06.08.38.58; Mon, 06 Sep 2021 08:39:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=WCfNNygV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243493AbhIFO6C (ORCPT + 99 others); Mon, 6 Sep 2021 10:58:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243528AbhIFO54 (ORCPT ); Mon, 6 Sep 2021 10:57:56 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD04CC061575 for ; Mon, 6 Sep 2021 07:56:51 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id m2so4821781wmm.0 for ; Mon, 06 Sep 2021 07:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=CtHiP+D7k5znLaPfpOQWBuuhn0SZQDsGXEHIILBBc1E=; b=WCfNNygVYAjJNE3QPiwsT3pzkIfLqzGlZq7FFjAb99YiilaQBopfe1sVzhYZzwsHKb P/1WE1p1AipRlP3kD+WRUNrrTwNA4wj2ONI8OQpwrLf/1ZGQyEjWZGiaeyBRDsjOdWy9 bI/xps0XWhbOXF3PB0ZfALeqob/0rqm68nOHITE74KPteoi3awxHyfAbR5Ty/rvfTJRe 2CSD2uEtVlokfkGKiPlWJmoDpzpRdJ3/6fd8DujAPhM34Vsljv2EoHDBTydX8ozILMFp EBwAfWl0gqnVgUpMkgXFekVYRf1VCwn58KNOyw5Ig2J9OywZZLbgomROXpS9D7eARKla b4yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=CtHiP+D7k5znLaPfpOQWBuuhn0SZQDsGXEHIILBBc1E=; b=rkk/w45OaVA1sHdJ0tMVOj/yS64gBl4B06oKQvQ/q3l9HFS6EyFpIJ1Y615d7PxtWa Dx/1Uq84NSzoegYCXDGxLX2juUZeuRe67SjM9jGgfn9gEufy9fuYZgVcLFmA5chjDQ7a dQu8JjT5gnoQSGM+6VWLtCtNMsyTexWBxsfyQtq1KBnWPSzLoS7QrRnDKKxmDhLc70eB vBrXwA5XZGhnRBsxYXLWWr/BG/v6ifUpQoKCv49cY722y+aITabAt46cl2ASRxE4RE93 htXlK6xhSmjLVdAUhVgX5Kb5pJncuLNLNRSU0AkFKtzCH+cH5aATCPJ+j3RMYsxss0k2 iBVA== X-Gm-Message-State: AOAM530TXkydAkLxqxsSlnJv2eplGIYfndJoLjIGcdEDDO6T17gbcZwF NAtJFMSL/zv+dSF22ZCCq6Q8zg== X-Received: by 2002:a7b:cc85:: with SMTP id p5mr11811897wma.42.1630940210493; Mon, 06 Sep 2021 07:56:50 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id g1sm251095wmk.2.2021.09.06.07.56.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Sep 2021 07:56:50 -0700 (PDT) Date: Mon, 6 Sep 2021 16:56:47 +0200 From: LABBE Corentin To: Hans Verkuil Cc: gregkh@linuxfoundation.org, mchehab@kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, mjpeg-users@lists.sourceforge.net Subject: Re: [PATCH 0/8] staging: media: zoran: fusion in one module Message-ID: References: <20210903191540.3052775-1-clabbe@baylibre.com> <940d5bdf-89b8-b5a4-f485-aa5b1c51286b@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <940d5bdf-89b8-b5a4-f485-aa5b1c51286b@xs4all.nl> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Mon, Sep 06, 2021 at 04:11:16PM +0200, Hans Verkuil a ?crit : > On 06/09/2021 15:49, LABBE Corentin wrote: > > Le Mon, Sep 06, 2021 at 01:03:56PM +0200, Hans Verkuil a ?crit : > >> Hi Corentin, > >> > >> I finally had the opportunity to test the staging zoran driver. > >> > >> I found several issues when running v4l2-compliance -s (I posted a patch > >> for that), but more seriously is the fact that trying to capture MJPG > >> at resolutions 384x288 or less just hangs my PC. It works OK with 768x576. > >> > >> I discovered this when running 'v4l2-compliance -s -a -f'. > >> > >> BTW, why isn't the initial format equal to MJPG 768x576? > >> I would expect that for these boards that should be the default format. > >> > >> Another issue is that the TODO should mention that for video output there > >> should be a second video device node. And that's really something that > >> has to be done before the zoran driver can be moved out of staging. > >> > >> It shouldn't be that hard to implement, I think. > >> > >> Right now it is impossible to run the compliance test for the output, since > >> it doesn't even see it as an output. > >> > >> Regards, > >> > >> Hans > > > > I work on having a second device for output, (it is the reason of "staging: media: zoran: move videodev alloc" which will help). > > > > But I still have the problem of non working output. > > > > Does output is really needed for going out of staging ? > > Probably nobody have it working for ages. The only way to had it was to use an old mplayer output which is broken since so many time. > > Note that this plugin will never work again. > > > > The only way to work on output is to use ffmpeg which just recently have suport for writing non-raw video to V4L. > > Then just remove it. The code for output remains in the git history so if someone wants to > resurrect that, then that's always possible. > > The point is that I don't want to have half-baked output support in mainline. > > But what exactly is the problem with getting output to work? Doesn't it just decode > MJPEG frames? (Sorry if you explained it before, it's so long ago that I looked at this > that I forgot the details) > The first problem is that zoran dont like comment COM/APP0 markers. This imply a per buffer filtering but this is already handled in my next branch. But the remaining problem is that any output is like http://kernel.montjoie.ovh/zoran_out.png. I hacked the driver to grab a working buffer when doing input and overrun output buffer later. And the result is a working static output. So the hw handling is good and the problem came from the data feeding/handling. I believe that something is wrong in what ffmpeg negociate/send. Regards