Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2948525pxb; Mon, 6 Sep 2021 08:51:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEPVz46zGIBEOtllOKgAEEMoGHQhG33sIi4ptHUFT5GMpGgWAyA2QvqRIYxNAdQ/n7nKli X-Received: by 2002:aa7:d854:: with SMTP id f20mr12801648eds.353.1630943509405; Mon, 06 Sep 2021 08:51:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630943509; cv=none; d=google.com; s=arc-20160816; b=LahKBziWKXiubPQEEuSEFTPV5JQM0edrZ6ncwBPxmf6nG6xEnTKJLkF2xfXLC0lhsq XUb9J4w+IuDesSIAZs75Hd+6Ii59snjQNRUqHfnAsfE+3mbZ7JAfoGMRzcRq1On3+zJu oYSvM86ur88JX3wlB3Or/0l8WtuoF88TRT7rVNxorRuMxbaJ7b+qxZqjXwo6r9+AQNeh WujZ8eKf5br0Q7Fukv0RvaXyPJur5X1NJKWuzQi2c4v3tizbZmx9DiRULVSS7wC6LS0U bB9/P+jFiCdCptnlDIDek0gJT5qr/Oy++rI/z6WeRQWgQd1NftSNZYg/QufNskD9z59R O/3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=nt+VP5itEeZryzlsoppIMhgjIIOE6d9H/YqxuE7x5BQ=; b=bLB+uWfcsXAaWFGVaxUTKkxVEG+/CUgiWIYce8p2KvfM2e/bUJgZoSbzew3e8ClzDz l9oQZTLaRzgDFGU+/e8By/7sL+H0h4e/aZF/nzXh8pLCtVDDMx9LCBgy2WD+ZKo+vEtH +abeVAr6F/5zid/lqUj13+PwjL9mbseEYUzzn7IdQswowNsqFAa/ogzt7MFkP0QS5OB0 lves523M2q3t6cGzs5y/OSjQx/Y6srGfNuSh7N4jgcrTzOjXdGc5zfmbuKRmcrFyfng4 /7GsedR3fHiNx+T2idO+EneHqc+VdXL8Oq6Tdz2gZg/mDU96ugxOyY0w99jqJliibt6z bqMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JJ60xXim; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l12si7994444edr.509.2021.09.06.08.51.25; Mon, 06 Sep 2021 08:51:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JJ60xXim; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242794AbhIFPvL (ORCPT + 99 others); Mon, 6 Sep 2021 11:51:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:56694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242432AbhIFPvK (ORCPT ); Mon, 6 Sep 2021 11:51:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id 4B8B960F9E; Mon, 6 Sep 2021 15:50:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630943405; bh=HqLRktkRBEJxR+5alQ8M/Dk+icix4Yp6GNAzyh2MS+Q=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=JJ60xXimupeOLrSIpfH4aNdgrOtsxNs28xBRzBrZLSuUb51bEYh3a5n6WnJ+w/J0X voiP168YGN8SIUyQffbKkaRjWYEdfuPmRDYLwH14V2aP0vm8yyuWix64GuJ50dLa8s 3Dl5wEcSGXmKYLx8ncTQxMjmDsIq9/3oG4EUNucBM5tVdxUZtC4qrKS2y8j9FscENj ful60HeyqkM2ltUq1OGuD1D2wI4L+xxprmnAk6HGef8nF1YxBD9u7Sto6o2f71Fmfj 6/9IwFA2/avCgJ6JNy9Nm4AeE300U9rkj/Y8Y5nkp0tOUDn3Zhgb5ByhnRqTT4tWYL jk22ACRl/PQWg== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id 3FE5460A37; Mon, 6 Sep 2021 15:50:05 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net: qcom/emac: Replace strlcpy with strscpy From: patchwork-bot+netdevbpf@kernel.org Message-Id: <163094340525.32353.11305691764552334355.git-patchwork-notify@kernel.org> Date: Mon, 06 Sep 2021 15:50:05 +0000 References: <20210906135653.109449-1-wangborong@cdjrlc.com> In-Reply-To: <20210906135653.109449-1-wangborong@cdjrlc.com> To: Jason Wang Cc: davem@davemloft.net, timur@kernel.org, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 6 Sep 2021 21:56:53 +0800 you wrote: > The strlcpy should not be used because it doesn't limit the source > length. As linus says, it's a completely useless function if you > can't implicitly trust the source string - but that is almost always > why people think they should use it! All in all the BSD function > will lead some potential bugs. > > But the strscpy doesn't require reading memory from the src string > beyond the specified "count" bytes, and since the return value is > easier to error-check than strlcpy()'s. In addition, the implementation > is robust to the string changing out from underneath it, unlike the > current strlcpy() implementation. > > [...] Here is the summary with links: - net: qcom/emac: Replace strlcpy with strscpy https://git.kernel.org/netdev/net/c/0a83299935f0 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html