Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp2968892pxb; Mon, 6 Sep 2021 09:14:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxj4IAXxHWFKtLQQ3gn5V8t7sZRnrq/YiMuy4tyupdhU1/IVMRsa8mIdj35wLDZscaainei X-Received: by 2002:a17:906:1d19:: with SMTP id n25mr14509936ejh.11.1630944899030; Mon, 06 Sep 2021 09:14:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630944899; cv=none; d=google.com; s=arc-20160816; b=Ze0qq2e4LOx4HiQI4lwxe9Uy6irzbpiPmeIBVTBdY7rt+23PQhLLEXGi+lQQcRptG8 pOxvsZPZxhU8x7HQQV3pGuIU1q0wua7Qbksx6BRARy53kUejLfL5QWmQgP2BDSeGze4a z19DfNEkcN4ntlDw+JneFGUnNISiZfBkPDW7kcySd4HXmLa46BmnGLnfxaM+dJksR40I AvX8vG0zH6gOCj9nVoXR3hbW+LTX1XdJOo8LB3VWt3RA455nDNPwTX8Mo/N7Dmy3cAhp 1niZyE6r7IyDDK62dJqlcfQW+Z400y7GYO4ezfKwhL3ydlSc16ugeTKHqrDF7F2R8hGY W9Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=hYS9+nltkRVvqUm5CmdhVmH+ALslv6xme21bOkTYocQ=; b=q7ukqdJXRgkdS3Yk2YBExDxS73A4EkDzM26TRtGFuwIND9h8aRxniG4Kj98PLuMfhC I3dm1GzUNha8ZnnFb/R2DLkVwzR+tVG91rVGp4Y0mR9kLn1KwQZjO6nUOVt5rDHMxW+U IKyMpGoj+wcchmeBDbKcbFxmpN/fZ6hB74OfgcXg4sAl+NYStnzhFQy+wo7PNn0jVQgL MURDW77dr83bmxn/cMju0sK/1OOTrEnHZ1duPBzi64gnO6Ruv42wOr/3M5brzEPxn7LT rc4A1MAdznzNnUxEN2n8opXZuWYX00p7tfYECcSAqXwFdx8zqDpGcjVnIiR4OdNTmTp5 JAMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=VYGGPZPN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cw1si9321500ejc.693.2021.09.06.09.14.34; Mon, 06 Sep 2021 09:14:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=VYGGPZPN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243840AbhIFQNj (ORCPT + 99 others); Mon, 6 Sep 2021 12:13:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238452AbhIFQNg (ORCPT ); Mon, 6 Sep 2021 12:13:36 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B926C06175F for ; Mon, 6 Sep 2021 09:12:31 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id s12so12159703ljg.0 for ; Mon, 06 Sep 2021 09:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hYS9+nltkRVvqUm5CmdhVmH+ALslv6xme21bOkTYocQ=; b=VYGGPZPNBbWCuSJ1UEVbkPjJq2Lyfd/u0WtP0VF5Pl5b8+dBnFmHXlVDSNRplBiDAH KszTYCunx4zsrA5cbC8iwV4WCjXhIgyPbwlQd18riW8k/UhlgyxmltKZiWdU5Ar0uzF8 ORkGrm6zw2qvK+d6Sm9faG2fYVydaGxRmVf5k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hYS9+nltkRVvqUm5CmdhVmH+ALslv6xme21bOkTYocQ=; b=sivGapfvS9C5eZsbADasfnwxQy33VJ3G9/mCfhSO2loi2DVY0RBdBFyAVlFv5KvAoj EYEZEgzoWdWREC+WIeyd4Ny4mz+lDhgT5NOLhcOQLi8fgxgM0xebzcVq8r+8XRP0HpDd QSGb0e2C6RIAQ5Q28dQ5JKlY/Ju1/gE1Gy3k4UtkrIEEqAzxjWvc8aEwZoBZZWaaoVsQ ASsUS/gFBWg81Mj3b5bYugD8tvqz8fHiPFOFc8QqUcG2wjZjrsCUbwLh24IJoAw1J9v+ tbhIS5bv/WwoFwjCdJp2ITQoDVCuMqPgxJJUjtfEDw4m66tU5h/9V1nmb+ITTxTv/ZSB 86Ew== X-Gm-Message-State: AOAM533l5xvfn7nM2zq0BpAhmgpikq+UNJU42rDn8AcxBOM2H9Gl4Me8 Npthr5wNyMfn9SApRcpinlhz9I5+3use4iewnzk= X-Received: by 2002:a2e:22c1:: with SMTP id i184mr11563602lji.89.1630944749155; Mon, 06 Sep 2021 09:12:29 -0700 (PDT) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com. [209.85.167.52]) by smtp.gmail.com with ESMTPSA id a13sm1111390ljn.120.2021.09.06.09.12.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Sep 2021 09:12:28 -0700 (PDT) Received: by mail-lf1-f52.google.com with SMTP id y34so14275879lfa.8 for ; Mon, 06 Sep 2021 09:12:28 -0700 (PDT) X-Received: by 2002:a05:6512:114c:: with SMTP id m12mr9963367lfg.150.1630944748158; Mon, 06 Sep 2021 09:12:28 -0700 (PDT) MIME-Version: 1.0 References: <20210906142615.GA1917503@roeck-us.net> In-Reply-To: <20210906142615.GA1917503@roeck-us.net> From: Linus Torvalds Date: Mon, 6 Sep 2021 09:12:12 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Enable '-Werror' by default for all kernel builds To: Guenter Roeck Cc: Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 6, 2021 at 7:26 AM Guenter Roeck wrote: > > Build results: > total: 153 pass: 89 fail: 64 Well, that sadly proves the point of that patch. x86-64 may be clean, because I have required it manually. Others not necessarily so much.. I've got at least one sparc64 fix in my inbox. It _might_ fix some other cases too (syscall checking), but I suspect it's one of those "death by a thousand cuts" situations, not just one or two issues that show up. Do you end up exposing the errors anywhere where I can take a look? If some of them are just because of bad tooling on certain architectures (ie fundamentally "this is unfixable, because we use gcc-XYZ that just always causes warnings") then those we could/should just disable -Werror for those and forget about them. But hopefully most cases are just "people haven't cared enough" and easily fixed. Linus