Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Cc:     saurav.girepunje@hotmail.com, Larry.Finger@lwfinger.net,
        phil@philpotter.co.uk, straube.linux@gmail.com,
        fmdefrancesco@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: core: remove duplicate structure.
To:     Greg KH <gregkh@linuxfoundation.org>
References: <YTSj7upqzTiccWH2@user> <YTYchKn/l3GboOsd@kroah.com>
From:   Saurav Girepunje <saurav.girepunje@gmail.com>
Message-ID: <4537b0fd-848e-5188-823b-3a3bb750391d@gmail.com>
Date:   Mon, 6 Sep 2021 22:10:04 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <YTYchKn/l3GboOsd@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 06/09/21 7:19 pm, Greg KH wrote:
> On Sun, Sep 05, 2021 at 04:33:10PM +0530, Saurav Girepunje wrote:
>> Remove duplicate structure mlme_handler and action_handler. Both
>> structure are having same member. Replace it with mlme_action_handler.
> 
> Why merge both names together?  Why not just pick one name and stick
> with that if they really do the same thing?
> 
> thanks,
> 
> greg k-h
> 

Yes, we can pick one name also . I think action_handler name will be better.

Thanks for review Greg,


Regards,
Saurav Girepunje