Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Cc:     saurav.girepunje@hotmail.com, Larry.Finger@lwfinger.net,
        florian.c.schilhabel@googlemail.com, fmdefrancesco@gmail.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Move similar execution in to a
 function.
To:     Greg KH <gregkh@linuxfoundation.org>
References: <YTUQZdPiYFscIsvU@user> <YTXjSwWcyd6RRMjO@kroah.com>
From:   Saurav Girepunje <saurav.girepunje@gmail.com>
Message-ID: <4b62cbec-b356-b920-17ba-3ee7cc6f9713@gmail.com>
Date:   Mon, 6 Sep 2021 22:20:05 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <YTXjSwWcyd6RRMjO@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 06/09/21 3:15 pm, Greg KH wrote:
> On Mon, Sep 06, 2021 at 12:15:57AM +0530, Saurav Girepunje wrote:
>> Move the common execution for read_macreg_hdl, write_macreg_hdl,
>> write_bbreg_hdl and write_rfreg_hdl in to a new function
>> common_read_write_hdl.
> 
> You said _what_ you did here, but not _why_ you did this.
> 
> I can't easily see why you did this, please explain it better in the
> next version of this patch.
> 
> thanks,
> 
> greg k-h
> 

Ok, I will add explanation and send next version.

Thanks for review greg.

Regards,
Saurav Girepunje