Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210904151628.6618-1-len.baker@gmx.com>
In-Reply-To: <20210904151628.6618-1-len.baker@gmx.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 6 Sep 2021 19:05:06 +0200
Message-ID: <CAJZ5v0inR2Sj3cRXYa3ip3hG1-1Gbv3QHExQmGO12AJmUjYB5w@mail.gmail.com>
Subject: Re: [PATCH] cpufreq: powernow: Prefer kcalloc over open coded arithmetic
To:     Len Baker <len.baker@gmx.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Kees Cook <keescook@chromium.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        linux-hardening@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Sep 4, 2021 at 5:16 PM Len Baker <len.baker@gmx.com> wrote:
>
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>
> So, use the purpose specific kcalloc() function instead of the argument
> size * count in the kzalloc() function.
>
> [1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
>
> Signed-off-by: Len Baker <len.baker@gmx.com>

I'm assuming that this patch will be picked up by the powerpc arch maintainers.

> ---
>  drivers/cpufreq/powernow-k7.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/powernow-k7.c b/drivers/cpufreq/powernow-k7.c
> index 5d515fc34836..a9d2c7bae235 100644
> --- a/drivers/cpufreq/powernow-k7.c
> +++ b/drivers/cpufreq/powernow-k7.c
> @@ -174,8 +174,8 @@ static int get_ranges(unsigned char *pst)
>         unsigned int speed;
>         u8 fid, vid;
>
> -       powernow_table = kzalloc((sizeof(*powernow_table) *
> -                               (number_scales + 1)), GFP_KERNEL);
> +       powernow_table = kcalloc(number_scales + 1, sizeof(*powernow_table),
> +                                GFP_KERNEL);
>         if (!powernow_table)
>                 return -ENOMEM;
>
> --
> 2.25.1
>