Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210906163831.263809-1-jfaracco@redhat.com> <56e17907-83d7-7b45-8b0f-5d80d9005c70@kernel.dk>
In-Reply-To: <56e17907-83d7-7b45-8b0f-5d80d9005c70@kernel.dk>
From:   Julio Faracco <jfaracco@redhat.com>
Date:   Mon, 6 Sep 2021 14:36:00 -0300
Message-ID: <CAHtYXivVcodcR5b2aYnFvhgAJ7yEr0+jYzPZ+w-JxRRzuWJyfA@mail.gmail.com>
Subject: Re: [PATCH] block: include dd_queued{,_show} into proper BLK_DEBUG_FS guard
To:     Jens Axboe <axboe@kernel.dk>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thanks Jens.

On Mon, Sep 6, 2021 at 1:44 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 9/6/21 10:38 AM, Julio Faracco wrote:
> > This commit fixes a compilation issue to an unused function if
> > BLK_DEBUG_FS setting is not enabled. This usually happens in tiny
> > kernels with several debug options disabled. For further details,
> > see the message below:
> >
> > ../block/mq-deadline.c:274:12: error: =E2=80=98dd_queued=E2=80=99 defin=
ed but not used [-Werror=3Dunused-function]
> >   274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio pri=
o)
> >       |            ^~~~~~~~~
> > cc1: all warnings being treated as errors
>
> This is like the 10th one of these... The patch has been queued up for
> about a week, if you check linux-next or the block tree. It's going
> upstream soon, in fact it was already sent in yesterday.

I noticed after seeing the same patch earlier this morning, but it was
too late to undo.
Discard my patch, pls.

>
> --
> Jens Axboe
>

--
Julio Faracco