Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp3112583pxb; Mon, 6 Sep 2021 12:38:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzyVX0GmeO09sdK+sZRr1x9dmsfmsEGoe0hR9DVrDoa+S/zp0dugO5np2asyJlaicNQFsr X-Received: by 2002:a92:cd85:: with SMTP id r5mr9639208ilb.213.1630957121580; Mon, 06 Sep 2021 12:38:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630957121; cv=none; d=google.com; s=arc-20160816; b=nxbP8EAnN3xiBH9FBp1zHcC2gWoXlEJ/CgRFmYp8dA3JWYrzrq3Rz2uSaatmloVPqE p2vjcGJVxoVX6AOVX3mWNwfBNjQiNU4IVwjA1H9jeJTsXK7bM//mVz+1c7qOxZdvR3RF YCslTKTj+ORMNjSMkvNKnz93rpoOJdApwQvNeh7Rf+Upqi3ohJGMhxsW7TuVUL6ociPZ qjW6t0rX7D3XYpJnAhKgmlALzxE+SFIA0GG8o4Pa/hQV6ur3PBJQAT9DnXxiN0KJMCvP o14+3E6thc6qLSujgga57qUzxGyPJC6kNf3YP3ZVctFqPkQYd0N91syl6YHNOw04bO4m q7Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=I71lkep6zOcslL4BykWHkhODqaJTjlyYljZt7QjV/g0=; b=l+cRWafTeAoiijlFipHXNPce4juxYPVi2MQFdOC5JQujQG+pXtTminQb37euYBStAe aOQkVICRBE/09EC0KeD52d9Dmj5t9wP44swRITh/3pz51a2HobYNgu+RoVg0StMXaN68 TTmXCfpVrUGM2NBd5axA3d5ms1K/uJ8q4sgV8m6U+FpWVR/dtNFOAzSTP6EsxBACjnD9 h4P0WI7qBXnLTjO8OJz1QHEFKgOY9JnQcEohXFg6sPYC6cvq8ruWsJOvVYexhi2Cqc9K dfjTD6KUIO2es874FPDeSYO4QRu1t6vc6wpB5uel7TasoPU48+2qg4IaNvfWpokkGqo8 ZiCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=N94F0YRE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r84si8424278jac.47.2021.09.06.12.38.30; Mon, 06 Sep 2021 12:38:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=N94F0YRE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343757AbhIFTFa (ORCPT + 99 others); Mon, 6 Sep 2021 15:05:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243572AbhIFTEH (ORCPT ); Mon, 6 Sep 2021 15:04:07 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5A39C06175F for ; Mon, 6 Sep 2021 12:03:01 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id mf2so15086611ejb.9 for ; Mon, 06 Sep 2021 12:03:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I71lkep6zOcslL4BykWHkhODqaJTjlyYljZt7QjV/g0=; b=N94F0YREbGRcpMj2XFkMp8wetZYYmLkfLk3WNG6u2eKeKZ73yVGuWqHbGlLu+EuFus uc0QAjAqBOFeOhJIyfPUuIrzmoyyxw5eAS0odzUaVsRmAk01BMdY92jH7btSvlyOYlku 1RQ0HX+Ny4D2I6XfC2+3ndbLHlNNKj7UgHnKg+6sgrb2FzzNjtN/sFxIeGomy4bDCE80 nFDSJLmKDduIeLjm9t48ZJMKqA/QjlOmAaQQSmweAxhVJISVOaw1nKwjXOei4ka4VZTs l3si4C3JQJ3wIQdWAv5bNYZh2S/5v5fdyIxLlXR9e549F0r/dmDy0PKx8uyJQgAXSiwv xehQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I71lkep6zOcslL4BykWHkhODqaJTjlyYljZt7QjV/g0=; b=JFWMfGo/jK0cbMqrynhK2CFlPysc8hOe9uyDitGSc8ExzvNbzZUnuxyp8zKTIJELgb fKo9B+86D+UEdtdAYnIvgBx/BrZS1hLGk31yb/3bn3YBnwfDZFgutB881DVe+Z4ygvvE 6cohQG1sG4V3H+BOSsWHuidruaS995Kkj+KzmJQtxMDScGGt3w7uZLcsSnJBS4SR/Zf+ 450ijwEbv3k985n1UebEX6IQQF2S7/lE1I8ZmxgztBXAdhT3saHOLzMsNcjGFORO/PxS yM9J+UpHk1ifVwQanP+3HwO/2BgzCW/ujvB2+ic7qunTav7HYvFNTG9iLNF1kCuHOOaV ZL/g== X-Gm-Message-State: AOAM531Aejyh4DvhPfuJ0awIBxSy3pBN51N26BoCouPV9LQm+lu6dIa1 2E99/MbcybWmBFvvmn3S564= X-Received: by 2002:a17:907:7f93:: with SMTP id qk19mr14371694ejc.433.1630954980057; Mon, 06 Sep 2021 12:03:00 -0700 (PDT) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::8fe1]) by smtp.gmail.com with ESMTPSA id k15sm4372018ejb.92.2021.09.06.12.02.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Sep 2021 12:02:59 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, martin@kaiser.cx, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v3 20/40] staging: r8188eu: remove sreset_get_wifi_status from hal_ops Date: Mon, 6 Sep 2021 21:02:03 +0200 Message-Id: <20210906190223.11396-21-straube.linux@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210906190223.11396-1-straube.linux@gmail.com> References: <20210906190223.11396-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove sreset_get_wifi_status from hal_ops and remove its wrapper rtw_hal_sreset_get_wifi_status(). Call sreset_get_wifi_status() directly instead. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/hal_intf.c | 9 --------- drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 2 -- drivers/staging/r8188eu/include/hal_intf.h | 4 ---- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 2 +- 4 files changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/staging/r8188eu/hal/hal_intf.c b/drivers/staging/r8188eu/hal/hal_intf.c index 1840c4046859..27adaea61f84 100644 --- a/drivers/staging/r8188eu/hal/hal_intf.c +++ b/drivers/staging/r8188eu/hal/hal_intf.c @@ -221,15 +221,6 @@ void rtw_hal_antdiv_rssi_compared(struct adapter *adapt, adapt->HalFunc.AntDivCompareHandler(adapt, dst, src); } -u8 rtw_hal_sreset_get_wifi_status(struct adapter *adapt) -{ - u8 status = 0; - - if (adapt->HalFunc.sreset_get_wifi_status) - status = adapt->HalFunc.sreset_get_wifi_status(adapt); - return status; -} - int rtw_hal_iol_cmd(struct adapter *adapter, struct xmit_frame *xmit_frame, u32 max_wating_ms, u32 bndy_cnt) { diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c index 0ee7da10633a..04c382e698f9 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -1803,8 +1803,6 @@ void rtl8188e_set_hal_ops(struct hal_ops *pHalFunc) pHalFunc->Efuse_PgPacketWrite = &rtl8188e_Efuse_PgPacketWrite; pHalFunc->Efuse_WordEnableDataWrite = &rtl8188e_Efuse_WordEnableDataWrite; - pHalFunc->sreset_get_wifi_status = &sreset_get_wifi_status; - pHalFunc->IOL_exec_cmds_sync = &rtl8188e_IOL_exec_cmds_sync; pHalFunc->hal_notch_filter = &hal_notch_filter_8188e; diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h index baa08d9346f9..f85385cc9288 100644 --- a/drivers/staging/r8188eu/include/hal_intf.h +++ b/drivers/staging/r8188eu/include/hal_intf.h @@ -193,8 +193,6 @@ struct hal_ops { u16 efuse_addr, u8 word_en, u8 *data, bool bPseudoTest); - u8 (*sreset_get_wifi_status)(struct adapter *padapter); - int (*IOL_exec_cmds_sync)(struct adapter *padapter, struct xmit_frame *frame, u32 max_wait, u32 bndy_cnt); @@ -269,8 +267,6 @@ void rtw_hal_antdiv_rssi_compared(struct adapter *padapter, struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src); -u8 rtw_hal_sreset_get_wifi_status(struct adapter *padapter); - int rtw_hal_iol_cmd(struct adapter *adapter, struct xmit_frame *xmit_frame, u32 max_wating_ms, u32 bndy_cnt); diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c index 803caf94da4c..19354eb41031 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2305,7 +2305,7 @@ static void rtw_dbg_mode_hdl(struct adapter *padapter, u32 id, u8 *pdata, u32 le rtw_hal_set_hwreg(padapter, HW_VAR_TRIGGER_GPIO_0, NULL); break; case GEN_MP_IOCTL_SUBCODE(GET_WIFI_STATUS): - *pdata = rtw_hal_sreset_get_wifi_status(padapter); + *pdata = sreset_get_wifi_status(padapter); break; default: break; -- 2.33.0