Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: bcain=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 39DFEC4338F
Reply-To: <bcain@codeaurora.org>
From:   "Brian Cain" <bcain@codeaurora.org>
To:     "'Jiapeng Chong'" <jiapeng.chong@linux.alibaba.com>
Cc:     <linux-hexagon@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1630920794-81114-1-git-send-email-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <1630920794-81114-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Subject: RE: [PATCH] trap: Fix warning comparing pointer to 0
Date:   Mon, 6 Sep 2021 21:23:01 -0500
Message-ID: <0bcb01d7a38f$48dd1c20$da975460$@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Thread-Index: AQGJRnG986NR9eU5XtbXbE4uuM19CKw0kYjg
Content-Language: en-us
Precedence: bulk

> -----Original Message-----
> From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Sent: Monday, September 6, 2021 4:33 AM
> To: bcain@codeaurora.org
> Cc: linux-hexagon@vger.kernel.org; linux-kernel@vger.kernel.org;
> chongjiapeng <jiapeng.chong@linux.alibaba.com>
> Subject: [PATCH] trap: Fix warning comparing pointer to 0
> 
> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
> 
> Fix the following coccicheck warning:
> 
> ./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
> ---
>  arch/hexagon/kernel/traps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c
> index edfc35d..3b6e0de 100644
> --- a/arch/hexagon/kernel/traps.c
> +++ b/arch/hexagon/kernel/traps.c
> @@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task,
> unsigned long *fp,
>  		}
> 
>  		/* Attempt to continue past exception. */
> -		if (0 == newfp) {
> +		if (!newfp) {
>  			struct pt_regs *regs = (struct pt_regs *) (((void
*)fp)
>  						+ 8);
> 

Reviewed-by: Brian Cain <bcain@codeaurora.org>