Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 7 Sep 2021 10:18:59 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Oliver Neukum <oneukum@suse.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, Jaejoong Kim <climbbb.kim@gmail.com>
Subject: Re: [PATCH] USB: cdc-acm: fix minor-number release
Message-ID: <YTcgc/wMDEpIpJG1@hovoldconsulting.com>
References: <20210906124339.22264-1-johan@kernel.org>
 <b0af8328-52c4-e5f8-5e11-36f95f32e735@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b0af8328-52c4-e5f8-5e11-36f95f32e735@suse.com>
Precedence: bulk

On Mon, Sep 06, 2021 at 03:02:43PM +0200, Oliver Neukum wrote:
> 
> On 06.09.21 14:43, Johan Hovold wrote:
> > @@ -1323,8 +1324,10 @@ static int acm_probe(struct usb_interface *intf,
> >  	usb_get_intf(acm->control); /* undone in destruct() */
> >  
> >  	minor = acm_alloc_minor(acm);
> > -	if (minor < 0)
> > +	if (minor < 0) {
> > +		acm->minor = ACM_TTY_MINORS;
> >  		goto err_put_port;

> Congratulations for catching that one.

Heh, thanks.

> May I request to improve understandability of the code that you give
> the constant a distinct name for this purpose? Something like
> 
> ACM_MINOR_POISON or ACM_INVALID_MINOR
> 
> so that normal people can understand the fixed code?

Sure, I'll use ACM_MINOR_INVALID.

Johan