Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp3576893pxb; Tue, 7 Sep 2021 02:57:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0EvmJwmJVjQwcf68gH04vv+Gy3MKcpCvWEU+uRQ7BhOoghwtdH1n2LqlccmawqBsXyqaf X-Received: by 2002:a17:907:d09:: with SMTP id gn9mr17912144ejc.447.1631008644089; Tue, 07 Sep 2021 02:57:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631008644; cv=none; d=google.com; s=arc-20160816; b=ItCxF/Y/Gn0km6UXJfTSZPNBaZNcdsNz2haVS+B+LxrL3NAmF0y6xnD+fzSDFMVJ9m RfIbHSG7/11dQxpvPe3ZIXl/mxHr4JYXdEUYtcqdngm8ih7zvZJ6S/f+zIlAeH8X2l6P 8gNd/xelKyT1Sz1iba4QDrXP1TfvvGiei30Fhe2sruXpg1MIJ0Iiwd0EPAayMF+C4OEW KIiBWpSeUbctyzZQUW/W/C83MNzkEx43yzqqHDjU6C7BminyZHyeP7p4g2Vtwrnf/2HG oapRzu+pdIkSrw4e8b8MTFAODt0hOyz0kXZKkuOnyExFCXmyXWdyoKEVNoFShtrrarGP KkQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=WSIOU+2sz+j6Nhef5MeDbLdEGnUQ+ENO9Rwr8raa5k4=; b=qqrV6+AguQus9cy0JXfhkXb7ts/WxWWuSxda4kGimfMoe73NDgb8hcdY6MZfYoLubh Bo7OEXYoM8gNWhl8vvSdcqiNFhL9/zXdpsCzNjlL3Vwx6DCmS4V61zzdmIKy1N9HyUhR a3TwBlN+rsCeZFTIOfldEZT+56FhPvac3OI2ufPa28hO9rTEKw3hjXj5002CJlLwJSZ1 n0bN3AuyvIphKckKxks9AkkqT2OQXCz8/x5QTAVTxWppdr352yHdd3+pgUUEwmTo6Pdw 1sCi1GmmEK8pXKDkO0paavAxhOPiXnjFRvqqaU+nHhoE6BF8iCxL7qtdvKVrmHPrVYGo SjRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si10621027edc.574.2021.09.07.02.57.01; Tue, 07 Sep 2021 02:57:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232709AbhIGJ4m (ORCPT + 99 others); Tue, 7 Sep 2021 05:56:42 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:29715 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbhIGJ4l (ORCPT ); Tue, 7 Sep 2021 05:56:41 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1879a3b9076087; Tue, 7 Sep 2021 17:36:03 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from localhost.localdomain (118.99.190.129) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Sep 2021 17:55:29 +0800 From: Steven Lee To: Linus Walleij , Bartosz Golaszewski , Joel Stanley , Andrew Jeffery , "open list:GPIO SUBSYSTEM" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list CC: , , , Subject: [PATCH -next v1 1/1] gpio: gpio-aspeed-sgpio: Fix wrong hwirq in irq handler. Date: Tue, 7 Sep 2021 17:55:25 +0800 Message-ID: <20210907095525.24668-2-steven_lee@aspeedtech.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210907095525.24668-1-steven_lee@aspeedtech.com> References: <20210907095525.24668-1-steven_lee@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [118.99.190.129] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1879a3b9076087 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The current hwirq is calculated based on the old GPIO pin order(input GPIO range is from 0 to ngpios - 1). It should be calculated based on the current GPIO input pin order(input GPIOs are 0, 2, 4, ..., (ngpios - 1) * 2). Signed-off-by: Steven Lee --- drivers/gpio/gpio-aspeed-sgpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-aspeed-sgpio.c b/drivers/gpio/gpio-aspeed-sgpio.c index 10f303d15225..3d6ef37a7702 100644 --- a/drivers/gpio/gpio-aspeed-sgpio.c +++ b/drivers/gpio/gpio-aspeed-sgpio.c @@ -395,7 +395,7 @@ static void aspeed_sgpio_irq_handler(struct irq_desc *desc) reg = ioread32(bank_reg(data, bank, reg_irq_status)); for_each_set_bit(p, ®, 32) - generic_handle_domain_irq(gc->irq.domain, i * 32 + p); + generic_handle_domain_irq(gc->irq.domain, i * 32 + p * 2); } chained_irq_exit(ic, desc); -- 2.17.1